Draft
ci: install asciidoc in deploy workflow before building HTML docs#17
Conversation
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: hub966 <205647957+hub966@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix failing GitHub Actions job deploy
ci: install asciidoc in deploy workflow before building HTML docs
Aug 6, 2026
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
Suppressed comments (1)
.github/workflows/static.yml:37
- ci/install-dependencies.sh already installs the documentation toolchain (including asciidoc) when jobname=Documentation (see ci/install-dependencies.sh:166-172). Adding a separate apt-get install step duplicates dependency management and may drift/miss other doc prerequisites. Prefer setting jobname for the existing dependency step and removing this extra install step.
- name: Install dependencies
run: ci/install-dependencies.sh
- name: Install asciidoc
run: sudo apt-get update -q && sudo apt-get install -y asciidoc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
deployGitHub Actions job was failing becauseasciidocis not pre-installed onubuntu-latestrunners, causingmake -C Documentation htmlto error out immediately.Changes
.github/workflows/static.yml: Added anInstall asciidocstep usingapt-getprior to the HTML documentation build step