Skip to content

Feature: Downgrade model validation severity to warnings #279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yangbobo2021 merged 2 commits into from
Feb 26, 2024
Merged

Feature: Downgrade model validation severity to warnings #279

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2e284d3
feat: Reduce model validation severity to warning
yangbobo2021 Feb 26, 2024
fa18068
refactor: Reduce model validation severity to warning
yangbobo2021 Feb 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions devchat/openai/openai_prompt.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,8 +232,8 @@ def _count_response_tokens(self) -> int:

def _validate_model(self, response_data: dict):
if not response_data['model'].startswith(self.model):
raise ValueError(f"Model mismatch: expected '{self.model}', "
f"got '{response_data['model']}'")
logger.warning("Model mismatch: expected '%s', got '%s'",
self.model, response_data['model'])

def _timestamp_from_dict(self, response_data: dict):
if not self._timestamp:
Expand Down
31 changes: 0 additions & 31 deletions tests/test_openai_prompt.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,37 +43,6 @@ def test_prompt_init_and_set_response():
assert prompt.responses[0].content == "The 2020 World Series was played in Arlington, Texas."


def test_prompt_model_mismatch():
name, email = get_user_info()
prompt = OpenAIPrompt(model="gpt-3.5-turbo", user_name=name, user_email=email)

response_str = '''
{
"choices": [
{
"finish_reason": "stop",
"index": 0,
"message": {
"content": "\\n\\n1, 2, 3, 4, 5, 6, 7, 8, 9, 10.",
"role": "assistant"
}
}
],
"created": 1677825456,
"id": "chatcmpl-6ptKqrhgRoVchm58Bby0UvJzq2ZuQ",
"model": "gpt-4",
"object": "chat.completion",
"usage": {
"completion_tokens": 301,
"prompt_tokens": 36,
"total_tokens": 337
}
}
'''
with pytest.raises(ValueError):
prompt.set_response(response_str)


@pytest.fixture(scope="module", name='responses')
def fixture_responses():
current_dir = os.path.dirname(__file__)
Expand Down