Skip to content

Refactor stream_response and add devchat_proxy setting #373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yangbobo2021 merged 2 commits into from
May 8, 2024
Merged

Refactor stream_response and add devchat_proxy setting #373

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d2c15e7
Refactor stream_response function to handle error responses and raise…
yangbobo2021 May 8, 2024
ae91933
Refactor error handling in stream_response function
yangbobo2021 May 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion devchat/assistant.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,10 @@ def iterate_response(self) -> Iterator[str]:
if self._chat.config.stream:
created_time = int(time.time())
config_params = self._chat.config.dict(exclude_unset=True)
for chunk in self._chat.stream_response(self._prompt):
stream_responses = self._chat.stream_response(self._prompt)
if not stream_responses:
raise RuntimeError("No response returned from the chat API")
for chunk in stream_responses:
try:
if hasattr(chunk, "dict"):
chunk = chunk.dict()
Expand Down
3 changes: 2 additions & 1 deletion devchat/openai/http_openai.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,8 @@ def stream_response(connection: http.client.HTTPSConnection, data, headers):
response = connection.getresponse()

if response.status != 200:
print(f"Error: {response.status} - {response.reason}")
print(f"Error: {response.status} - {response.reason} {response.read()}",
end="\n\n", file=sys.stderr)
return None
return LineReader(response=response)

Expand Down