fix: denylist adversarial fixtures and wrap parsing with catch_unwind#86
Merged
developer0hye merged 3 commits intomainfrom Mar 1, 2026
Merged
fix: denylist adversarial fixtures and wrap parsing with catch_unwind#86developer0hye merged 3 commits intomainfrom
developer0hye merged 3 commits intomainfrom
Conversation
Add all fuzzer-generated, crash reporter, XML bomb, and OOM-inducing test fixtures to the bulk conversion denylist. This covers: - 15 DOCX: clusterfuzz, crash reporter, deep-table-cell, truncated - 11 PPTX: clusterfuzz, Divino_Revelado (OOM/hang) - 23 XLSX: clusterfuzz, crash reporters, 58616, XML bombs, OOM The test_denylist_filtering test now also verifies minimum counts per format (>=14 DOCX, >=10 PPTX, >=15 XLSX). Related: #85, #77 Signed-off-by: Yonghye Kwon <developer.0hye@gmail.com>
Wrap parser.parse() with catch_unwind in convert_bytes() so panics from umya-spreadsheet / docx-rs become ConvertError::Parse instead of propagating to the caller. Applies to both normal and streaming XLSX paths. Add extract_panic_message() helper to extract human-readable messages from caught panic payloads. Add upstream_panics_return_error test verifying that known-panicking fixtures (chart_hyperlink.xlsx, check-boolean.xlsx) return Err instead of panicking. Related: #77 Signed-off-by: Yonghye Kwon <developer.0hye@gmail.com>
This file causes a CI timeout in the bulk third-party fixture test. Add it to the denylist to prevent blocking CI. Refs: #85 Signed-off-by: Yonghye Kwon <developer.0hye@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
parser.parse()calls withstd::panic::catch_unwindinconvert_bytes()andconvert_bytes_streaming_xlsx()so that panics from upstream libraries (umya-spreadsheet, docx-rs) are caught and returned asConvertError::Parseinstead of propagatingupstream_panics_return_errorintegration test verifying known-panicking fixtures returnErrKey changes
lib.rs:catch_unwindaround parse calls +extract_panic_message()helperbulk_conversion.rs: Expanded denylist from 9 → 49 entries with per-format coverage assertionsxlsx_fixtures.rs: Newupstream_panics_return_errortestRelated: #77, #85, #83, #84
🤖 Generated with Claude Code