fix: Typst codegen bugs for math markup and edge cases#87
Merged
developer0hye merged 1 commit intomainfrom Mar 1, 2026
Merged
Conversation
- Add groupChr element handling for OMML overbrace/underbrace (US-310) - Fix subscript/superscript parentheses via existing wrap_if_needed (US-311) - Handle empty radicand in sqrt/root with placeholder (US-312) - Fix delimiter balancing by omitting empty delimiter pairs (US-313) - Wrap non-ASCII alphabetic text in math mode with upright() (US-314) - Escape brackets and braces in text content for Typst (US-315) - Fall back to solid fill for single-stop gradients (US-316) Closes #80, Closes #81 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Yonghye Kwon <developer.0hye@gmail.com>
3780013 to
0200b47
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
groupChrelement handling — maps OMML⏞(overbrace) and⏟(underbrace) to Typstoverbrace()/underbrace()functionswrap_if_needed(); added regression testssqrt()/root()— emit placeholder""instead of missing argument to prevent Typst "missing argument: radicand" errorbegChrorendChris empty, omit both delimiters to prevent unmatched bracket errors in Typstupright("...")to prevent Typst "unknown variable" errors[,],{,}in text content alongside existing Typst special character escaping to prevent premature content block closureRelated: #80, #81
Test plan
cargo test --workspacepasses (722+ tests)cargo fmt --all -- --checkpassescargo clippy --workspace -- -D warningspasses🤖 Generated with Claude Code