Mitigate upstream dependency failures (docx-rs, umya-spreadsheet)#89
Merged
developer0hye merged 2 commits intomainfrom Mar 1, 2026
Merged
Mitigate upstream dependency failures (docx-rs, umya-spreadsheet)#89developer0hye merged 2 commits intomainfrom
developer0hye merged 2 commits intomainfrom
Conversation
Add library identifiers (docx-rs, umya-spreadsheet) to ConvertError::Parse messages so users can distinguish between upstream parse failures and our own code errors. Also enrich the catch_unwind panic warning in the DOCX parser to clearly indicate "upstream panic caught (docx-rs)" with panic detail text. Refs: #83, #84 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Yonghye Kwon <developer.0hye@gmail.com>
Evaluate calamine (v0.33.0) as a potential replacement for umya-spreadsheet for XLSX parsing. Test results show calamine handles 17/22 of the failing fixtures, but it cannot extract cell formatting (fonts, colors, borders), which is required for PDF conversion fidelity. Recommendation: stay with umya-spreadsheet, monitor calamine for formatting support, consider partial hybrid fallback in the future. Refs: #83 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Yonghye Kwon <developer.0hye@gmail.com>
developer0hye
force-pushed
the
ralph/phase17-upstream-mitigations
branch
from
4cc8d3a to
54ccb6c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ConvertError::Parsemessages so users can identify the source of parse failures"upstream panic caught (docx-rs)"prefix and panic detail textcalamineas an alternative XLSX parser (17/22 failing fixtures pass, but lacks formatting support)Changes
Code changes (US-330)
parser/docx.rs: Parse error message now includes(docx-rs)library name; panic-caught warnings include library name and panic detailparser/xlsx.rs: Parse error messages now include(umya-spreadsheet)library nameUpstream tracking (US-331)
Research (US-332)
docs/xlsx-parser-evaluation.md: Comparison of calamine vs umya-spreadsheetRelated: #83, #84
Test plan
cargo test -p office2pdf --lib— 703 tests passcargo test -p office2pdf --test docx_fixtures --test xlsx_fixtures --test pptx_fixtures— all fixture tests passcargo fmt --all -- --check— passescargo clippy --workspace -- -D warnings— passes🤖 Generated with Claude Code