feat: patch umya-spreadsheet to fix 12 of 15 XLSX panics#90
Merged
developer0hye merged 3 commits intomainfrom Mar 1, 2026
Merged
feat: patch umya-spreadsheet to fix 12 of 15 XLSX panics#90developer0hye merged 3 commits intomainfrom
developer0hye merged 3 commits intomainfrom
Conversation
Add [patch.crates-io] to use developer0hye/umya-spreadsheet fork (fix/panic-safety-v2 branch) which replaces 15+ panic-causing unwrap() calls with graceful error handling. Files that previously panicked (e.g., chart_hyperlink.xlsx, check-boolean.xlsx) now convert successfully. Update the test to reflect this improvement. Related: #83 Signed-off-by: Yonghye Kwon <developer.0hye@gmail.com>
Cargo.lock is in .gitignore for this library workspace. Signed-off-by: Yonghye Kwon <developer.0hye@gmail.com>
Add comprehensive tests for all 15 previously-panicking XLSX files: - 12 files now convert successfully (were: FileNotFound, ParseFloatError, unwrap on None, dataBar EOF panics) - 3 files still return clean errors via catch_unwind (arithmetic overflow and remaining unwrap on None in other code paths) All 7 previously-erroring files remain unchanged (zip-level errors). Summary: panic count reduced from 15 to 3 (80% improvement), successful conversions increased by 12 files. Related: #83 Signed-off-by: Yonghye Kwon <developer.0hye@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
umya-spreadsheet(v2.3.3) to replace 15+ panic-causingunwrap()calls andpanic!()macros with graceful error handling[patch.crates-io]in workspaceCargo.tomlChanges
umya-spreadsheet fork (fix/panic-safety-v2)
Fixes applied to 11 files in the fork:
raw_file.rsunwrap()data_bar.rs,icon_set.rsreturnon EOF instead ofpanic!()icon_set.rs"dataBar"end element instead of"iconSet"u_int32_value.rs,int32_value.rstry_fromwith fallback for out-of-range valuesnumber_format.rs,number_formater.rs,percentage_formater.rsunwrap_ordefaults for numeric parsingstylesheet.rs,cell.rs,conditional_formatting_rule.rsif let/unwrap_or_defaultfor missing styles/elementsoffice2pdf integration
Cargo.toml: Add[patch.crates-io]pointing to fork'sfix/panic-safety-v2branchResults
catch_unwindFiles now converting successfully (12)
chart_hyperlink.xlsx,hyperlink.xlsx,tdf130959.xlsx,test_115192.xlsx47504.xlsx,bug63189.xlsx,ConditionalFormattingSamples.xlsxcheck-boolean.xlsx,tdf100709.xlsx,sample-beta.xlsxtdf162948.xlsx,NewStyleConditionalFormattings.xlsxFiles still failing with clean errors (3)
functions-excel-2010.xlsx— arithmetic overflow in formula parsingFormulaEvalTestData_Copy.xlsx— arithmetic overflow in formula parsing64450.xlsx—unwrap()onNonein a different code pathTest plan
cargo test --workspacepassescargo fmt --all -- --checkpassescargo clippy --workspace -- -D warningspassesErr(no process crash)Related: #83
🤖 Generated with Claude Code