fix: resolve all 9 remaining XLSX parsing failures#92
Merged
developer0hye merged 1 commit intomainfrom Mar 1, 2026
Merged
Conversation
Update umya-spreadsheet fork to pick up fixes for 9 remaining XLSX failures: backslash zip paths, missing styles.xml, arithmetic overflows, and missing XML attributes. All 21 previously-panicking files (from issue #83) now produce valid PDFs. Remove the remaining_panic_files_return_clean_errors test and merge those 9 files into previously_panicking_files_now_convert. Signed-off-by: Yonghye Kwon <developer.0hye@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
remaining_panic_files_return_clean_errorstest intopreviously_panicking_files_now_convertRoot causes fixed in umya-spreadsheet fork
A. Backslash zip path separators (3 files:
tdf131575,tdf76115,49609)zip_by_name()helper that normalizes path separators and cased3p1:idinstead ofr:id)B. Missing optional
xl/styles.xml(3 files:56278,tdf121887,59021)FileNotFoundgraceful handling pattern (same asshared_strings.rs)C. Arithmetic overflow & unwrap on None (3 files)
functions-excel-2010.xlsx: Usesaturating_add/saturating_subin coordinate mathFormulaEvalTestData_Copy.xlsx: Wideni32toi64with.min(18)cap64450.xlsx: Guardraw_relationship.rsattributes withlet-elseTest plan
Related: #83
🤖 Generated with Claude Code