Fix remaining 4 DOCX failures from issue #84#93
Merged
developer0hye merged 1 commit intomainfrom Mar 1, 2026
Merged
Conversation
Add fixture tests for the last 4 DOCX files from issue #84: - tdf171025_pageAfter.docx — ODT with .docx extension (clean error) - tdf171038_pageAfter.docx — ODT with .docx extension (clean error) - math-malformed_xml.docx — malformed XML (clean error) - deep-table-cell.docx — 5000+ nested tables (clean error via depth limit) Remove deep-table-cell.docx from the bulk conversion DENYLIST since the docx-rs fork depth-limit fix prevents stack overflow. Related: #84 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Yonghye Kwon <developer.0hye@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MAX_TABLE_DEPTH = 32)ReaderError::TableDepthExceedederror variant to distinguish depth-limit errors from other XML parse errorsTableCell::read()while keeping tolerance for other table parse errorstdf171025_pageAfter.docx— ODT file with .docx extension (clean parse error)tdf171038_pageAfter.docx— ODT file with .docx extension (clean parse error)math-malformed_xml.docx— intentionally malformed XML (clean parse error)deep-table-cell.docx— 5000+ nested tables (clean error via depth limit, no stack overflow)deep-table-cell.docxfrom the bulk conversion DENYLISTTest plan
cargo test --workspacepasses (all tests green)cargo fmt --all -- --checkpassescargo clippy --workspace -- -D warningspassesRelated: #84
🤖 Generated with Claude Code