fix: add depth limits to prevent stack overflow on deeply nested tables#98
Merged
developer0hye merged 1 commit intomainfrom Mar 1, 2026
Merged
Conversation
Add MAX_TABLE_DEPTH (64) constant to both the DOCX parser and Typst renderer. Deeply nested tables beyond this limit are silently truncated instead of causing a stack overflow. Parser (docx.rs): - convert_table(), extract_raw_rows(), extract_cell_content() now accept a depth parameter; top-level callers pass 0 - extract_cell_content() skips nested tables when depth >= MAX_TABLE_DEPTH Renderer (typst_gen.rs): - GenCtx gains a table_depth field (default 0) - generate_table() increments/decrements depth via a wrapper - generate_cell_content() skips Block::Table when depth >= MAX_TABLE_DEPTH Fixes #94 Signed-off-by: Yonghye Kwon <developer.0hye@gmail.com> Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Yonghye Kwon <developer.0hye@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MAX_TABLE_DEPTH(64) constant to both the DOCX parser and Typst renderer to prevent stack overflow on pathological documents with thousands of nested tablesdocx.rs): threads adepthparameter throughconvert_table()→extract_raw_rows()→extract_cell_content(); silently truncates nesting beyond the limittypst_gen.rs): addstable_depthfield toGenCtx;generate_table()increments/decrements depth,generate_cell_content()skips nested tables at the limitRelated: #94
Test plan
cargo test -p office2pdf --test docx_fixtures smoke_deep_table_cellpasses (no stack overflow)cargo test --workspace— all tests passcargo fmt --all -- --check— cleancargo clippy --workspace -- -D warnings— clean🤖 Generated with Claude Code