Feat/fix periodic test breakage

[KevinDanikowski]

issue with periodic test failure was due to folders being deleted containing the same name tmp from the two different test files. I solved it by using a random int in the name for the folder creation.

[jamesxliu]

Interesting, so this makes me wonder if the introduction of nyc changed the timing of the afterEach/afterAll hooks containing rimraf cbs clearing the tmpdirs

[jamesxliu]

The tests aren't breaking on the master branch right? Just breaking in the other pull request branch. That branch introduces nyc into the test runner mix.

[KevinDanikowski]

@jamesxliu it breaks on master. it only works periodically. i don't believe it has to do with nyc but perhaps it could.

[jamesxliu]

Whoah, haven't run into that. Pretty hilarious though, I pulled down the branch to reproduce the issue, tests pass, I switch to the fix/codeCoverage branch and kablammo, build failures in /tmp

[developher-net]

It happens for me when I switch branches even without NYC involved. Perhaps running ‘npm install’ in tmp is doing something that conflicts with node_modules in the parent folder. But I have no explanation why that would have worked fine in the past.

[developher-net]

Even if this doesn't fix the issue, this is a change that I wanted to implement to reduce the chance of issues caused by collisions between test runs. Exactly the approach I intended to implement. Thanks for tackling this!

[developher-net]

🎉 This issue has been resolved in version 3.6.2 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀