Support for Preact X#69
Merged
developit merged 3 commits intodevelopit:masterfrom Jul 10, 2019
pl12133:preactX
Merged
Conversation
This was referenced Jun 12, 2019
1 task
Contributor
|
Oh shoot I completely forgot to check existing PRs when doing #70 :( |
developit
reviewed
Jul 10, 2019
|
|
||
| // assert that an object is JSX (or more correctly, a VNode) | ||
| let isJsx = obj => obj && (options.isJsx ? options.isJsx(obj) : (obj.__isVNode || isVNode(obj))); | ||
| let isJsx = obj => obj && (options.isJsx ? options.isJsx(obj) : (obj._vnode || isVNode(obj))); |
Owner
There was a problem hiding this comment.
I'm going to merge this, but @pl12133 I can't seem to remember what __isVNode was being used for. It doesn't seem to have ever been in preact or compat. Do you know?
Collaborator
Author
There was a problem hiding this comment.
I went through some history and it seems like this was in preact since the beginning, but it must have been removed a long time ago:
developit
approved these changes
Jul 10, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It looks like the shape of a VNode has changed, so
preact-jsx-chaihas stopped finding VNodes and the calls toexpect(...).to.eql(...)have stopped working correctly.Still working on getting all the tests to pass.
TODO: