Skip to content

Missing returns for Node.{insertBefore, appendChild, replaceChild, removeChild} #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
developit merged 3 commits into from
Jan 22, 2018
Merged

Missing returns for Node.{insertBefore, appendChild, replaceChild, removeChild} #15

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1cc8dfd
insertBefore should return childNode that was inserted, to match dom …
andyrj Oct 2, 2017
a460f0a
correcting whitespace
andyrj Oct 2, 2017
6408cda
missing returns for appendChild, replaceChild, removeChild
andyrj Oct 2, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/undom.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,21 +51,24 @@ export default function undom() {
}
appendChild(child) {
this.insertBefore(child);
return child;
}
insertBefore(child, ref) {
child.remove();
child.parentNode = this;
if (!ref) this.childNodes.push(child);
else splice(this.childNodes, ref, child);
!ref ? this.childNodes.push(child) : splice(this.childNodes, ref, child);
Copy link
Owner

@developit developit Oct 2, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is pretty much what Uglify does (haven't checked).

Copy link
Contributor Author

@andyrj andyrj Oct 2, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Eslint complained when I simply added return after the if/else as it thought the return was only for the else case. So I switched to the ternary.

Copy link
Contributor Author

@andyrj andyrj Oct 2, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not that changing simply because eslint says so is the right thing, but in this case it does seem to make things clearer with the ternary imo.

return child;
}
replaceChild(child, ref) {
if (ref.parentNode===this) {
this.insertBefore(child, ref);
ref.remove();
return ref;
}
}
removeChild(child) {
splice(this.childNodes, child);
return child;
}
remove() {
if (this.parentNode) this.parentNode.removeChild(this);
Expand Down