Apply context when dispatching event#6
Merged
developit merged 1 commit intodevelopit:masterfrom Feb 20, 2017
jamesbirtles:patch-1
Merged
Apply context when dispatching event#6developit merged 1 commit intodevelopit:masterfrom jamesbirtles:patch-1
developit merged 1 commit intodevelopit:masterfrom
jamesbirtles:patch-1
Conversation
`this` inside of event listeners should be the element that the listener was registered on. Without this, dispatching events on preact elements was failing with `Cannot read property 'click' of undefined`
Owner
|
[funny: I had typed out a whole reply about preact before I realized this was undom haha] Happy to merge this, was laziness on my part to forget the first time around. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
thisinside of event listeners should be the element that the listener was registered on.Without this, dispatching events on preact elements was failing with
Cannot read property 'click' of undefinedfor example