update sample#7
Merged
Merged
Conversation
Signed-off-by: Stephanie <yangcao@redhat.com>
…-with-quarkus into remove-outerloop-term
Remove outerloop term
Signed-off-by: Stephanie <yangcao@redhat.com> Signed-off-by: Stephanie <yangcao@redhat.com>
|
@yangcao77 @maysunfaisal @elsony Found this bug today as well that the "Basic Quarkus" Devfile sample doesn't work on OpenShift. It fails with: Tested this branch and it starts fine 👍 |
maysunfaisal
approved these changes
Nov 1, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
update devfile, remove outerloop terms. add service definition to the repo, add route definition in deploy component.
update the dockerfile script permission to fix the run failure.
tested with odo and odc.