Add Global Attributes, Global Variable & Substitution and Deprecate Metadata.Attributes#352
Merged
Merged
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Maysun J Faisal maysunaneek@gmail.com
What does this PR do?
{{attributeKey}}whereattributeKeyis the key entry in the global attributeschemaVersion&metadata{{}}as value in the devfile📌 EDIT POST DEVFILE CABAL AND PR REVIEW DISCUSSION:
Post Devfile cabal call & PR review discussion, the above criteria has been modified, Please refer #352 (comment) for the PR acceptance criteria
What issues does this PR fix or reference?
Fixes #239
Is your PR tested? Consider putting some instruction how to test your changes
Yes, updated current tests for overriding & merging and added new go tests.
Docs PR