refactor(hub)!: drop synthesized built-in docks for integration-owned ~builtin views#92
Merged
Conversation
… ~builtin views
The hub no longer synthesizes ~terminals/~messages/~settings dock entries. A high-level integration now registers the built-in views it wants, and a ~builtin-typed view defaults its own category to ~builtin. The ~builtin category is retained for ordering (it still sorts last).
BREAKING CHANGE: Removed the BuiltinDocksOptions type and the createHubContext `builtinDocks` option, and DevframeDocksHost.values() no longer accepts { includeBuiltin }. Integrations register the settings/terminals/messages docks themselves.
✅ Deploy Preview for devfra ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the
BuiltinDocksconcept from@devframes/hub. The hub previously synthesized~terminals/~messages/~settingsdock entries and gated them through abuiltinDocksoption. That responsibility now belongs to the high-level integration that assembles the hub.devframe:docksreflects exactly what integrations register.~builtincategory is retained and still sorts last.type: '~builtin'view defaults its owncategoryto~builtin, so an integration registering one needn't repeat it.The
minimal-nextexample now registers its own~settingsdock to demonstrate the integration-owned model.Breaking changes
BuiltinDocksOptionstype and thecreateHubContext({ builtinDocks })option.DevframeDocksHost.values()no longer accepts{ includeBuiltin }.This PR was created with the help of an agent.