feat(hub): support dock defaults on DevframeDefinition#94
Merged
Conversation
Add a `dock` option to DevframeDefinition carrying default dock attributes for the iframe entry a hub synthesizes. mountDevframe merges these beneath its per-mount `dock` overrides, which in turn sit beneath the locked, derived id/type/url.
✅ Deploy Preview for devfra ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intent
Let a devframe author declare default dock attributes directly on its
DevframeDefinition, so the appearance of the dock entry a hub synthesizes (category, order, visibility, badge, group, title/icon overrides) can travel with the tool itself rather than being specified only at every mount site.What changed
DevframeDefinition.dock— a new optional field typed as the new framework-neutralDevframeDockDefaultsinterface (title, icon, defaultOrder, category, when, badge, groupId). Metadata-only, sincedevframesits belowhuband can't depend on the hub's dock types.mountDevframenow merges the definition'sdockdefaults into the synthesized iframe entry, beneath its per-mountoptions.dockoverrides. Precedence: locked derivedid/type/url← per-mountoptions.dock← definitiond.dock←name/icon-derived defaults. Standalone adapters (cli/spa/build) ignore it.Notes
Two tests cover the merge (defaults applied; per-mount overrides win). The
devframeAPI snapshots are updated for the new export. The pre-existingwithBuiltinCategory/~builtintest failures on the base branch are untouched and unrelated to this change.This PR was created with the help of an agent.