Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #885 +/- ##
==========================================
+ Coverage 40.66% 40.79% +0.13%
==========================================
Files 115 117 +2
Lines 10885 11014 +129
==========================================
+ Hits 4426 4493 +67
- Misses 6065 6127 +62
Partials 394 394 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
8c906c7 to
4a875b1
Compare
There was a problem hiding this comment.
Pull request overview
Adds a new “wireless state” feature that exposes Intel AMT WiFi enabled/disabled state via HTTP and wires it through the devices usecase to WSMAN CIM_WiFiPort (Enumerate/Pull + RequestStateChange).
Changes:
- Added HTTP API route
networkSettings/wireless/statewith GET (read state) and POST (request state change). - Added devices usecase methods to read/request wireless state via WSMAN CIM_WiFiPort Enumerate/Pull and RequestStateChange.
- Added DTOs and regenerated mocks + unit tests for the new behavior.
Reviewed changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| internal/usecase/devices/wsman/message.go | Adds WiFiPort Enumerate/Pull helpers and makes WiFiRequestStateChange accept a requestedState argument. |
| internal/usecase/devices/wsman/interfaces.go | Extends WSMAN Management interface with WiFiPort Enumerate/Pull and WiFiRequestStateChange(requestedState). |
| internal/usecase/devices/wifistate.go | New usecase logic for requesting wireless state changes and reading current wireless state. |
| internal/usecase/devices/wifistate_test.go | New unit tests covering the new usecase methods and error paths. |
| internal/usecase/devices/interfaces.go | Extends devices Feature interface with RequestWirelessStateChange and GetWirelessState. |
| internal/entity/dto/v1/wifistate.go | New DTOs/constants for wireless requested states and responses. |
| internal/controller/httpapi/v1/wifistate.go | New HTTP handlers for GET/POST wireless state. |
| internal/controller/httpapi/v1/wifistate_test.go | New HTTP handler tests for wireless state endpoints. |
| internal/controller/httpapi/v1/devicemanagement.go | Registers the new wireless state routes under /amt/networkSettings/wireless/state/:guid. |
| internal/controller/ws/v1/interface.go | Extends WS feature interface to include wireless state methods. |
| internal/mocks/wsman_mocks.go | Regenerated mocks to include new WSMAN interface methods. |
| internal/mocks/wsv1_mocks.go | Regenerated mocks to include new WS feature methods. |
| internal/mocks/devicemanagement_mocks.go | Regenerated mocks to include new devices Feature methods. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
4a875b1 to
ff18af1
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 13 out of 13 changed files in this pull request and generated 5 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ff18af1 to
782ee80
Compare
782ee80 to
08b3660
Compare
Changes
networkSettings/wireless/stateAPI routeGetWirelessStateandRequestWirelessStateChangemethodsEnabledStateWiFiRequestStateChangeto take inrequestedStateargument and request for therequestedStateCIM_WiFiPort class ref: link
NOTE:
This PR is to fulfill the API part of issue #836 , the UI part will be designed together with other network settings configuration issues.
Testing