Do not expose public macros with common names#531
Conversation
The prevents compatibility issues with other libraries, such as the one seen in devkitPro#530 Fixes devkitPro#530
|
While we understand the frustration and the rationale behind this PR, unfortunately we cannot accept it because this would entail a major breaking change, specifically the removal of the commonly used |
|
Well, my PR to libfmt also got closed fmtlib/fmt#3633 😅 |
|
@fincs Would you accept a PR that removes or prefixes macros other than |
The mitigates compatibility issues with other libraries, such as the one seen in devkitPro#530. The `BIT` macro is kept because it is commonly used, so removing it would be too breaking of a change (see devkitPro#531 (comment)) Fixes devkitPro#530
The mitigates compatibility issues with other libraries, such as the one seen in devkitPro#530. The `BIT` macro is kept because it is commonly used, so renaming it would be too breaking of a change (see devkitPro#531 (comment)) Fixes devkitPro#530
Well, what you can do is just not include libctru headers in the same file as libfmt headers. You might want to point out to libfmt maintainers that "PACKED" is most commonly used for our precise use case & not theirs. See https://github.com/search?q=%22%23define+PACKED+%22&type=code for instance. It seems rather late in the day to be making intrusive & breaking changes like this. |
3 participants
The prevents compatibility issues with other libraries, such as the one seen in #530
Fixes #530