Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: devlooped/GitInfo
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: b01ecea
Choose a base ref
...
head repository: devlooped/GitInfo
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: ca66be5
Choose a head ref
  • 3 commits
  • 4 files changed
  • 3 contributors

Commits on Feb 7, 2023

  1. Configuration menu
    Copy the full SHA
    5748632 View commit details
    Browse the repository at this point in the history

Commits on Feb 8, 2023

  1. Bump ThisAssembly.AssemblyInfo from 1.2.4 to 1.2.5

    Bumps [ThisAssembly.AssemblyInfo](https://github.com/devlooped/ThisAssembly) from 1.2.4 to 1.2.5.
    - [Release notes](https://github.com/devlooped/ThisAssembly/releases)
    - [Changelog](https://github.com/devlooped/ThisAssembly/blob/main/changelog.md)
    - [Commits](devlooped/ThisAssembly@v1.2.4...v1.2.5)
    
    ---
    updated-dependencies:
    - dependency-name: ThisAssembly.AssemblyInfo
      dependency-type: direct:production
      update-type: version-update:semver-patch
    ...
    
    Signed-off-by: dependabot[bot] <support@github.com>
    dependabot[bot] authored and kzu committed Feb 8, 2023
    Configuration menu
    Copy the full SHA
    d485b19 View commit details
    Browse the repository at this point in the history

Commits on Feb 9, 2023

  1. Set Version and PackageVersion to a default value

    It's not entirely intuitive that you install GitInfo and by default
    "nothing happens", as in, you get new code from ThisAssembly,
    but otherwise, no versioning changes happen. This might be
    counterintuitive to newcomers, who might just care to get
    something (a sensible default) going, before investing more
    in customizing GitInfo.
    
    This is how MinVer does it (provided there's a version tag
    in the repository) and it's quite intuitive.
    
    The way we do it here should be mostly backwards compat
    because:
    1. Users leveraging assembly-version attributes will already
        have disabled .NET SDK assembly attribute generation
    2. Users leveraging MSBuild targets to do this would be
        following the recommended guidance of creating a target
        that runs before specific targets, not as InitialTargets
    
    We make our version-setting target run as an inital target,
    which may have a minor impact on initial build perf, but
    but shouldn't be a problem since the same targets are
    run for DTB anyway (if you make them run before
    GetAssemblyVersion, which also runs before
    BeforeCompile and CoreCompile in the SDK).
    
    By being an initial target, we allow for existing customization
    in pretty much any target, prevail our own one, which becomes
    just a default.
    
    Even so, we check for GitVersion=false as an escape hatch for
    users who may encounter unforseen broken scenarios.
    kzu committed Feb 9, 2023
    Configuration menu
    Copy the full SHA
    ca66be5 View commit details
    Browse the repository at this point in the history
Loading