Make retry logic more resilient to changes in xunit/vstest output#62
Merged
Make retry logic more resilient to changes in xunit/vstest output#62
Conversation
There was a significant change in output from dotnet test/vstest/xunit which caused us to bail too early and not retry properly.
We know the output (for now?) will contain the phrasing `Results file: {path}\{filename}.trx`, but we don't want to make that detection too fragile either. So we just check for the presence of the directory we pass as results dir, which should be always available in standard output.
Fixes #48
Member
Author
|
🧪 Details on macOS Unix 14.7.2✅ Sample.UnitTest1.FailsOnce 🧪 Details on Ubuntu 24.04.1 LTS✅ Sample.UnitTest1.FailsOnce 🧪 Details on Microsoft Windows 10.0.20348✅ Sample.UnitTest1.FailsOnce from dotnet-retest v42.42.201-pr62 on .NET 8.0.12 with 💜 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was a significant change in output from dotnet test/vstest/xunit which caused us to bail too early and not retry properly.
We know the output (for now?) will contain the phrasing
Results file: {path}\{filename}.trx, but we don't want to make that detection too fragile either. So we just check for the presence of the directory we pass as results dir, which should be always available in standard output.Fixes #48