Implement IEmbeddingGenerator interface on top of Embedder.EmbedderClient#41
Closed
Implement IEmbeddingGenerator interface on top of Embedder.EmbedderClient#41
Conversation
Member
🧪 Details on Ubuntu 24.04.3 LTSfrom retest v1.1.0 on .NET 10.0.1 with 💜 by @devlooped |
…ient Co-authored-by: kzu <169707+kzu@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Implement IEmbeddingGenerator interface on EmbedderClient
Implement IEmbeddingGenerator interface on top of Embedder.EmbedderClient
Jan 3, 2026
kzu
requested changes
Jan 5, 2026
Co-authored-by: kzu <169707+kzu@users.noreply.github.com>
Contributor
Author
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GrokEmbeddingGeneratorclass implementingIEmbeddingGenerator<string, Embedding<float>>GrokClientExtensionsfor creating embedding generatorsSummary
This PR implements the
IEmbeddingGenerator<string, Embedding<float>>interface on top of theEmbedder.EmbedderClientfrom the xAI Protocol. The implementation follows the same patterns as the existingGrokChatClientimplementation and the reference OpenAI implementation from the dotnet/extensions repository.Changes
New
GrokEmbeddingGeneratorclass (src/xAI/GrokEmbeddingGenerator.cs)IEmbeddingGenerator<string, Embedding<float>>GenerateAsyncmethod converts input strings toEmbedInputprotocol messages and calls the gRPCEmbedserviceGetServiceimplementation returns metadata and underlying clientEmbeddingUsageresponse toUsageDetailsExtension methods in
GrokClientExtensions(src/xAI/GrokClientExtensions.cs)AsIEmbeddingGenerator(this GrokClient client, string defaultModelId)AsIEmbeddingGenerator(this Embedder.EmbedderClient client, string defaultModelId)Throw.IfNullfor all extension methodsComprehensive tests (
src/xAI.Tests/EmbeddingGeneratorTests.cs)Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.