#1760: accept empty input for one option#1803
Merged
hohwille merged 6 commits intoApr 10, 2026
Merged
Conversation
…nput for tool version choices
|
|
…ronment configuration
Collaborator
Coverage Report for CI Build 24230232616Coverage decreased (-0.004%) to 70.466%Details
Uncovered ChangesNo uncovered changes found. Coverage Regressions70 previously-covered lines in 2 files lost coverage.
Coverage Stats
💛 - Coveralls |
jakozian
reviewed
Apr 8, 2026
…management and add corresponding unit tests
hohwille
approved these changes
Apr 9, 2026
Member
hohwille
left a comment
hohwille
left a comment
There was a problem hiding this comment.
@ducminh02 excellent KISS fix and great test improvement to cover the functionality. 👍
Please add to CHANGELOG, then ready for merge.
github-project-automation
Bot
moved this from Team Review
to 👀 In review
in IDEasy board
hohwille
added
security
MarvMa
pushed a commit
to MarvMa/IDEasy
that referenced
this pull request
Apr 17, 2026
MarvMa
pushed a commit
to MarvMa/IDEasy
that referenced
this pull request
Apr 17, 2026
laim2003
added a commit
to laim2003/IDEasy
that referenced
this pull request
Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #1760
Implemented changes:
Updated displayOptionsAndGetAnswer in AbstractIdeContext.java to automatically select a single available option only if it is not a vulnerable tool version, ensuring users must still explicitly accept version-related risks.
Adjusted the unit test in IdeContextTest.java to use a real Cve (vulnerability) object, verifying that the system correctly stops to prompt the user when a single but "unsafe" version is offered.
Checklist for this PR
Make sure everything is checked before merging this PR. For further info please also see
our DoD.
mvn clean testlocally all tests pass and build is successful#«issue-id»: «brief summary»(e.g.#921: fixed setup.bat). If no issue ID exists, title only.In Progressand assigned to you or there is no issue (might happen for very small PRs)with
internal