Skip to content

#1915 add minikube url updater#1916

Open
AdemZarrouki wants to merge 4 commits into
devonfw:mainfrom
AdemZarrouki:feature/1915-add-minikube-url-updater
Open

#1915 add minikube url updater#1916
AdemZarrouki wants to merge 4 commits into
devonfw:mainfrom
AdemZarrouki:feature/1915-add-minikube-url-updater

Conversation

@AdemZarrouki
Copy link
Copy Markdown
Contributor

@AdemZarrouki AdemZarrouki commented May 11, 2026

This PR fixes #1915

Implemented changes:

  • Added MinikubeUrlUpdater using GithubUrlReleaseUpdater

Checklist for this PR

Make sure everything is checked before merging this PR. For further info please also see
our DoD.

  • When running mvn clean test locally all tests pass and build is successful
  • PR title is of the form #«issue-id»: «brief summary» (e.g. #921: fixed setup.bat). If no issue ID exists, title only.
  • PR top-level comment summarizes what has been done and contains link to addressed issue(s)
  • PR and issue(s) have suitable labels
  • Issue is set to In Progress and assigned to you or there is no issue (might happen for very small PRs)
  • You followed all coding conventions
  • You have added the issue implemented by your PR in CHANGELOG.adoc unless issue is labeled
    with internal

@github-project-automation github-project-automation Bot moved this to 🆕 New in IDEasy board May 11, 2026
@AdemZarrouki AdemZarrouki self-assigned this May 11, 2026
@AdemZarrouki AdemZarrouki added enhancement New feature or request urls ide-urls repo and related processes and features labels May 11, 2026
@coveralls
Copy link
Copy Markdown
Collaborator

coveralls commented May 11, 2026

Coverage Report for CI Build 25907655608

Coverage decreased (-0.04%) to 70.64%

Details

  • Coverage decreased (-0.04%) from the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • 16 coverage regressions across 2 files.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

16 previously-covered lines in 2 files lost coverage.

File Lines Losing Coverage Coverage
com/devonfw/tools/ide/url/updater/UpdateManager.java 13 0.0%
com/devonfw/tools/ide/version/VersionSegment.java 3 88.19%

Coverage Stats

Coverage Status
Relevant Lines: 15493
Covered Lines: 11410
Line Coverage: 73.65%
Relevant Branches: 6922
Covered Branches: 4424
Branch Coverage: 63.91%
Branches in Coverage %: Yes
Coverage Strength: 3.12 hits per line

💛 - Coveralls

@AdemZarrouki AdemZarrouki marked this pull request as ready for review May 11, 2026 12:31
@AdemZarrouki AdemZarrouki requested a review from KarimALotfy May 11, 2026 12:34
@AdemZarrouki AdemZarrouki moved this from 🆕 New to Team Review in IDEasy board May 11, 2026
@KarimLotfy2000
Copy link
Copy Markdown

Great work! 👏
I tested it using <path-to-ide-urls> PT1H minikube, and the URLs for different tool versions were successfully resolved and installed locally.
I have no further comments.

@AdemZarrouki AdemZarrouki moved this from Team Review to 👀 In review in IDEasy board May 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request urls ide-urls repo and related processes and features

Projects

Status: 👀 In review

Development

Successfully merging this pull request may close these issues.

Create MinikubeUrlUpdater

4 participants