Skip to content

#799: clean code improvements#884

Merged
hohwille merged 2 commits into
devonfw:mainfrom
hohwille:feature/799-zip-x-flag-clean-code
Dec 10, 2024
Merged

#799: clean code improvements#884
hohwille merged 2 commits into
devonfw:mainfrom
hohwille:feature/799-zip-x-flag-clean-code

Conversation

@hohwille
Copy link
Copy Markdown
Member

@hohwille hohwille commented Dec 10, 2024

cleanup of code style after PR #835

@hohwille hohwille added enhancement New feature or request core FileAccess, ProcessUtil, IdeContext, etc. internal Nothing to be added to CHANGELOG, only internal story labels Dec 10, 2024
@hohwille hohwille added this to the release:2024.12.001 milestone Dec 10, 2024
@hohwille hohwille self-assigned this Dec 10, 2024
@hohwille hohwille linked an issue Dec 10, 2024 that may be closed by this pull request
binaries from zip download lack executable flags #799
Closed
jan-vcapgemini
jan-vcapgemini approved these changes Dec 10, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@jan-vcapgemini jan-vcapgemini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. LGTM.

@coveralls
Copy link
Copy Markdown
Collaborator

coveralls commented Dec 10, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 12255203109

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 50 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.003%) to 67.1%
Files with Coverage Reduction New Missed Lines %
com/devonfw/tools/ide/io/FileAccessImpl.java 50 62.74%
Totals Coverage Status
Change from base Build 12254980253: -0.003%
Covered Lines: 6626
Relevant Lines: 9528
💛 - Coveralls

@hohwille hohwille merged commit 7866298 into devonfw:main Dec 10, 2024
MarvMa pushed a commit to MarvMa/IDEasy that referenced this pull request Apr 17, 2026
@hohwille
devonfw#799: clean code improvements (devonfw#884)
7733a3a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@jan-vcapgemini jan-vcapgemini jan-vcapgemini approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@hohwille hohwille

Labels

core FileAccess, ProcessUtil, IdeContext, etc. enhancement New feature or request internal Nothing to be added to CHANGELOG, only internal story

Projects

IDEasy board
Status: ✅ Done

Milestone

release:2024.12.001

Development

Successfully merging this pull request may close these issues.

binaries from zip download lack executable flags

3 participants

@hohwille @coveralls @jan-vcapgemini