Skip to content

dynamic client support and some utilities#93

Merged
m-wcislo merged 22 commits into
devopsspiral:masterfrom
mertkayhan:feature/dynamic-client-and-utilities
Oct 3, 2021
Merged

dynamic client support and some utilities#93
m-wcislo merged 22 commits into
devopsspiral:masterfrom
mertkayhan:feature/dynamic-client-and-utilities

Conversation

@mertkayhan

@mertkayhan mertkayhan commented Aug 2, 2021

Copy link
Copy Markdown
Contributor

<Remember to add meaningful title>

<Short description of the PR>

I have been working with KubeLibrary in Openshift for a while now. I implemented some new features/utilities which made my life easier in my project. Hereby, I would like to add them to the KubeLibrary since they may help the community too.

Fixes #<issue number>

Before merge following needs to be applied:

  • At least one example testcase added in testcases/
  • Library Documentation regenerated according to Generate docs
  • PR entry added in CHANGELOG.md in In progress section
  • All new testcases tagged as prerelease along other tags to exclude it from execution until released on PyPI
  • Coverage threshold increased in .coveragerc if new coverage is higher than actual, see the lint-and-coverage step in CI
fail_under = 67

@m-wcislo

Copy link
Copy Markdown
Collaborator

I need to take a closer look, but meanwhile would it be possible to add some examples for create, patch, .. or any of them, that would be very useful.

@mertkayhan

Copy link
Copy Markdown
Contributor Author

Hello @m-wcislo, I have added some examples under testcases/dynamic_client

@m-wcislo m-wcislo left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution. This looks really nice, especially things like:

${conf}=     read conf     testcases/dynamic_client/resources/pod.yaml
create pod     ${conf}

I've added couple comments. Also please go through the checklist from the PR description before it is ready to merge.

Comment thread setup.py Outdated
Comment thread src/KubeLibrary/KubeLibrary.py Outdated
Comment thread src/KubeLibrary/KubeLibrary.py Outdated
Comment thread src/KubeLibrary/KubeLibrary.py Outdated
Comment thread src/KubeLibrary/KubeLibrary.py Outdated
Comment thread testcases/dynamic_client/dynamic_client.robot Outdated
Comment thread src/KubeLibrary/KubeLibrary.py Outdated
Comment thread testcases/dynamic_client/dynamic_client.robot Outdated
Comment thread requirements.txt Outdated
Comment thread src/KubeLibrary/KubeLibrary.py Outdated
Comment thread src/KubeLibrary/KubeLibrary.py Outdated
Comment thread test/test_KubeLibrary.py
Comment thread test/test_KubeLibrary.py
Comment thread src/KubeLibrary/KubeLibrary.py Outdated
Comment thread test/test_KubeLibrary.py

@devopsspiral devopsspiral left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, it looks good. The missing thing is that wait_pod_completion is somehow still there and please complete the checklist in PR description, like coverage threshold increase, generate docs etc.

@m-wcislo m-wcislo left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect. Could you only bump the .coveragerc to 84. Don't want to these coverage efforts to be lost by someone else.

@m-wcislo
m-wcislo merged commit 73a233d into devopsspiral:master Oct 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants