dynamic client support and some utilities#93
Conversation
|
I need to take a closer look, but meanwhile would it be possible to add some examples for create, patch, .. or any of them, that would be very useful. |
|
Hello @m-wcislo, I have added some examples under |
m-wcislo
left a comment
There was a problem hiding this comment.
Thanks for your contribution. This looks really nice, especially things like:
${conf}= read conf testcases/dynamic_client/resources/pod.yaml
create pod ${conf}
I've added couple comments. Also please go through the checklist from the PR description before it is ready to merge.
…nt to tests && fix testcases
devopsspiral
left a comment
There was a problem hiding this comment.
OK, it looks good. The missing thing is that wait_pod_completion is somehow still there and please complete the checklist in PR description, like coverage threshold increase, generate docs etc.
m-wcislo
left a comment
There was a problem hiding this comment.
Perfect. Could you only bump the .coveragerc to 84. Don't want to these coverage efforts to be lost by someone else.
<Remember to add meaningful title>
<Short description of the PR>
I have been working with KubeLibrary in Openshift for a while now. I implemented some new features/utilities which made my life easier in my project. Hereby, I would like to add them to the KubeLibrary since they may help the community too.
Fixes #<issue number>
Before merge following needs to be applied: