Skip to content

"Angular Upgrade: Incremental Approach (v13 → v19)"#379

Closed
yashchauhan4579 wants to merge 4 commits into
devsecopsmaturitymodel:masterfrom
yashchauhan4579:angular-upgrade
Closed

"Angular Upgrade: Incremental Approach (v13 → v19)"#379
yashchauhan4579 wants to merge 4 commits into
devsecopsmaturitymodel:masterfrom
yashchauhan4579:angular-upgrade

Conversation

@yashchauhan4579
Copy link
Copy Markdown

Angular Upgrade (Incremental v13 → v19)
Summary
This draft PR aims to upgrade the Angular version of DSOMM from v13 to v19 incrementally to ensure smooth transitions and minimize breaking changes.
Approach
Started with v13, upgrading step-by-step to v14, v15, v16, etc.
Addressed dependency changes and fixed compatibility issues.
Testing after each upgrade to ensure stability.
Current Progress
*Upgraded to v14
*Next: Upgrading to v15
Next Steps
*Continue incremental upgrades until v19.
*Fix potential issues and dependencies along the way.

@vbakke
Copy link
Copy Markdown
Collaborator

vbakke commented Mar 23, 2025

Thank you for your effort, @yashchauhan4579 🙌 🏆
I really appreciate this, and I'm looking forward to the rest.

(I'm no Angular expert so I'll refrain from reviewing, but from what I could tell, it looked all good : )

@0x41head
Copy link
Copy Markdown
Collaborator

Thanks for the efforts @yashchauhan4579 ! Let me know if you run across any issues. I would be happy to guide you.

@vbakke
Copy link
Copy Markdown
Collaborator

vbakke commented Mar 26, 2025

@yashchauhan4579: I just want to clarify your thoughts of progress.

Are you planning on upgrading all the steps until v19 in this PR? Or do you want to split it up in multiple PRs?

Also, do you have a rough timeline? No pressure, what so ever. Main aim is coordinating any other changes.

If you feel like a pause before reaching v19, please let us know and tag 0x41head. Then we can do the review of the progress, and close / merge this PR. (And enabling merging any other UI issues in between. : )

@yashchauhan4579
Copy link
Copy Markdown
Author

Thanks for the acknowledgment, @0x41head! I appreciate your support. I'll reach out if I run into any issues.👍🏻

@yashchauhan4579
Copy link
Copy Markdown
Author

Thanks for checking in, @vbakke! I’m currently progressing step by step with the upgrade to ensure stability at each stage. I’m also considering the approach of structuring it into multiple PRs if that helps streamline reviews and maintain better coordination. Before finalizing the strategy, I’d like to discuss this with @0x41head to align on the best course of action. I’ll assess the progress and confirm the next steps accordingly. Proper coordination is essential to facilitate seamless upgrades while accommodating other UI changes. Thanks again!

@yashchauhan4579
Copy link
Copy Markdown
Author

yashchauhan4579 commented Apr 2, 2025

Hi @vbakke, coming back to you with an update! I plan to complete the full upgrade to v19 in a single PR. I estimate it will take around 2-3 weeks to ensure stability and prevent regressions, if thereafter there is a need for stretch I would actively Inform. And If I run into any hurdles during the process, I'll consult with @0x41head to ensure everything moves forward smoothly. I hope this aligns well with the ongoing processes!

@vbakke
Copy link
Copy Markdown
Collaborator

vbakke commented Apr 2, 2025

Sounds great! 🙂👍
No other ongoing changes I am aware of, apart from the dark theme change, and a centralised loader.

@github-actions
Copy link
Copy Markdown

This PR has been automatically marked as stale because it has not had recent activity. 📆 It will be closed automatically in two weeks if no further activity occurs.

@github-actions github-actions Bot added the Stale label Apr 27, 2025
@vbakke
Copy link
Copy Markdown
Collaborator

vbakke commented Apr 30, 2025

I'll just put a comment here, so the issue is not auto-closed

@github-actions github-actions Bot removed the Stale label May 1, 2025
@github-actions
Copy link
Copy Markdown

This PR has been automatically marked as stale because it has not had recent activity. 📆 It will be closed automatically in two weeks if no further activity occurs.

@github-actions github-actions Bot added the Stale label May 22, 2025
@vbakke
Copy link
Copy Markdown
Collaborator

vbakke commented May 23, 2025

How are you doing, @yashchauhan4579?
Shall we let the PR drop, or are you tinkering in the background? :)

@github-actions github-actions Bot removed the Stale label May 24, 2025
@github-actions
Copy link
Copy Markdown

This PR has been automatically marked as stale because it has not had recent activity. 📆 It will be closed automatically in two weeks if no further activity occurs.

@github-actions github-actions Bot added the Stale label Jun 13, 2025
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jul 3, 2025

This PR was closed because it has been stalled for 20 days with no activity.

@github-actions github-actions Bot closed this Jul 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants