Skip to content

fix(lifecycle): warn when waitFor references phase with no commands#120

Merged
skevetter merged 1 commit into
mainfrom
fix/waitfor-empty-phase-warning
Apr 25, 2026
Merged

fix(lifecycle): warn when waitFor references phase with no commands#120
skevetter merged 1 commit into
mainfrom
fix/waitfor-empty-phase-warning

Conversation

@skevetter

Copy link
Copy Markdown
Contributor

Summary

Re-implementation of #107. Adds a debug-level warning when the waitFor phase has no commands configured, indicating the split point is a no-op. Also adds InitTestObserved to pkg/log for capturing log output in tests, and 4 new tests covering phaseHasCommands behavior and the warning log emission.

@netlify

netlify Bot commented Apr 25, 2026

Copy link
Copy Markdown

Deploy Preview for devsydev canceled.

Name Link
🔨 Latest commit ff0c8b1
🔍 Latest deploy log https://app.netlify.com/projects/devsydev/deploys/69ecdd60d23a6f0008d8d68f

@coderabbitai

coderabbitai Bot commented Apr 25, 2026

Copy link
Copy Markdown

Warning

Rate limit exceeded

@skevetter has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 56 minutes and 2 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 56 minutes and 2 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: c9aca569-408d-47fc-b2f4-ed0443f5f6c3

📥 Commits

Reviewing files that changed from the base of the PR and between 377bac9 and ff0c8b1.

📒 Files selected for processing (3)
  • pkg/devcontainer/setup/lifecyclehooks.go
  • pkg/devcontainer/setup/lifecyclehooks_test.go
  • pkg/log/testing.go

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@skevetter
skevetter enabled auto-merge (squash) April 25, 2026 16:08
@skevetter
skevetter disabled auto-merge April 25, 2026 16:11
@skevetter
skevetter merged commit 60f5b1a into main Apr 25, 2026
47 checks passed
@skevetter
skevetter deleted the fix/waitfor-empty-phase-warning branch April 25, 2026 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant