fix(lifecycle): warn when waitFor references phase with no commands#107
fix(lifecycle): warn when waitFor references phase with no commands#107skevetter wants to merge 1 commit into
Conversation
Log a debug message when the resolved waitFor phase has no commands configured, making it easier to diagnose no-op split points.
✅ Deploy Preview for devsydev canceled.
|
|
Warning Rate limit exceeded
Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 56 minutes and 50 seconds. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Closing: main is being reverted to 3701855. Will re-implement cleanly after revert. |
Summary
phaseHasCommandshelper that checks whether a lifecycle phase carries any configured commands or a custom runFuncRunPreAttachHookswhen the resolvedwaitForphase has no commands, making no-op split points easier to diagnoseInitTestObservedtopkg/logfor test-observable log capture via zap's observerphaseHasCommandstrue/false/runFunc cases and warning-is-logged assertionLocal validation:
task cli:test— setup package tests all pass (pre-existing GPG test failures in cmd/ are unrelated)task cli:lint:new— 0 issues