Skip to content

fix(lifecycle): warn when waitFor references phase with no commands#107

Closed
skevetter wants to merge 1 commit into
mainfrom
fix/waitfor-empty-phase-warning
Closed

fix(lifecycle): warn when waitFor references phase with no commands#107
skevetter wants to merge 1 commit into
mainfrom
fix/waitfor-empty-phase-warning

Conversation

@skevetter

Copy link
Copy Markdown
Contributor

Summary

  • Add phaseHasCommands helper that checks whether a lifecycle phase carries any configured commands or a custom runFunc
  • Log a debug message in RunPreAttachHooks when the resolved waitFor phase has no commands, making no-op split points easier to diagnose
  • Add InitTestObserved to pkg/log for test-observable log capture via zap's observer
  • Add 4 unit tests: phaseHasCommands true/false/runFunc cases and warning-is-logged assertion

Local validation:

  • task cli:test — setup package tests all pass (pre-existing GPG test failures in cmd/ are unrelated)
  • task cli:lint:new — 0 issues

Log a debug message when the resolved waitFor phase has no commands
configured, making it easier to diagnose no-op split points.
@netlify

netlify Bot commented Apr 25, 2026

Copy link
Copy Markdown

Deploy Preview for devsydev canceled.

Name Link
🔨 Latest commit 165501f
🔍 Latest deploy log https://app.netlify.com/projects/devsydev/deploys/69ec10b2cc24940007baab11

@coderabbitai

coderabbitai Bot commented Apr 25, 2026

Copy link
Copy Markdown

Warning

Rate limit exceeded

@skevetter has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 56 minutes and 50 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 56 minutes and 50 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 982b24e8-c89a-428a-a8ec-78e6dcf736d9

📥 Commits

Reviewing files that changed from the base of the PR and between a5e7e27 and 165501f.

📒 Files selected for processing (3)
  • pkg/devcontainer/setup/lifecyclehooks.go
  • pkg/devcontainer/setup/lifecyclehooks_test.go
  • pkg/log/testing.go

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@skevetter

Copy link
Copy Markdown
Contributor Author

Closing: main is being reverted to 3701855. Will re-implement cleanly after revert.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant