Skip to content

fix(run): respect user-specified consistency in workspaceMount#182

Merged
skevetter merged 2 commits into
mainfrom
d226/ws-mount-consistency
May 3, 2026
Merged

fix(run): respect user-specified consistency in workspaceMount#182
skevetter merged 2 commits into
mainfrom
d226/ws-mount-consistency

Conversation

@skevetter

Copy link
Copy Markdown
Contributor

Summary

  • Parse user's workspaceMount string for an existing consistency= value before applying the default consistency='consistent' on non-Linux
  • Generalize nerdctl consistency stripping to handle all consistency values (delegated, cached, etc.), not just the hardcoded 'consistent'
  • Add E2E test with consistency=delegated in workspaceMount to verify mount string is preserved

Spec alignment

The official devcontainers CLI respects user-specified consistency values in workspaceMount strings (ref: github.com/devcontainers/cli src/spec-node/containerFeatures.ts mount handling). This change aligns our behavior:

  • User-specified consistency=delegated or consistency=cached is now preserved on Docker
  • Default consistency='consistent' is still applied on non-Linux when no consistency is specified
  • Linux behavior unchanged (no consistency option added)
  • Nerdctl correctly strips all consistency values (not just 'consistent'), since nerdctl doesn't support this Docker Desktop-specific option
  • Standard devcontainer.json compatibility is preserved — no intentional divergences

Parse the user's workspaceMount string for an existing consistency value.
Only apply the default consistency='consistent' on non-Linux if the user
hasn't specified one. Also generalize nerdctl consistency stripping to
handle all consistency values, not just the hardcoded 'consistent'.
@netlify

netlify Bot commented May 3, 2026

Copy link
Copy Markdown

Deploy Preview for devsydev canceled.

Name Link
🔨 Latest commit 56daaa8
🔍 Latest deploy log https://app.netlify.com/projects/devsydev/deploys/69f791e92d631a0008f44113

@skevetter
skevetter enabled auto-merge (squash) May 3, 2026 18:11
@coderabbitai

coderabbitai Bot commented May 3, 2026

Copy link
Copy Markdown

Warning

Rate limit exceeded

@skevetter has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 44 minutes and 40 seconds before requesting another review.

To keep reviews running without waiting, you can enable usage-based add-on for your organization. This allows additional reviews beyond the hourly cap. Account admins can enable it under billing.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 0e8c6737-eb9a-4860-9287-6f1f41b43831

📥 Commits

Reviewing files that changed from the base of the PR and between a148fb3 and 56daaa8.

📒 Files selected for processing (6)
  • e2e/tests/up/provider_docker.go
  • e2e/tests/up/testdata/docker-workspace-mount-consistency/.devcontainer.json
  • pkg/devcontainer/run.go
  • pkg/devcontainer/run_test.go
  • pkg/driver/docker/docker.go
  • pkg/driver/docker/docker_test.go

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
Review rate limit: 0/1 reviews remaining, refill in 44 minutes and 40 seconds.

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions Bot added the size/m label May 3, 2026
Satisfies goconst linter rule for string with 4+ occurrences.
@skevetter
skevetter merged commit d7bb5ed into main May 3, 2026
51 checks passed
@skevetter
skevetter deleted the d226/ws-mount-consistency branch May 3, 2026 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant