fix(run): respect user-specified consistency in workspaceMount#182
Conversation
Parse the user's workspaceMount string for an existing consistency value. Only apply the default consistency='consistent' on non-Linux if the user hasn't specified one. Also generalize nerdctl consistency stripping to handle all consistency values, not just the hardcoded 'consistent'.
✅ Deploy Preview for devsydev canceled.
|
|
Warning Rate limit exceeded
To keep reviews running without waiting, you can enable usage-based add-on for your organization. This allows additional reviews beyond the hourly cap. Account admins can enable it under billing. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (6)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Review rate limit: 0/1 reviews remaining, refill in 44 minutes and 40 seconds.Comment |
Satisfies goconst linter rule for string with 4+ occurrences.
Summary
workspaceMountstring for an existingconsistency=value before applying the defaultconsistency='consistent'on non-Linux'consistent'consistency=delegatedin workspaceMount to verify mount string is preservedSpec alignment
The official devcontainers CLI respects user-specified consistency values in workspaceMount strings (ref:
github.com/devcontainers/clisrc/spec-node/containerFeatures.ts mount handling). This change aligns our behavior:consistency=delegatedorconsistency=cachedis now preserved on Dockerconsistency='consistent'is still applied on non-Linux when no consistency is specified'consistent'), since nerdctl doesn't support this Docker Desktop-specific option