Skip to content

fix(ux): replace %w with %v in log format strings #129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
skevetter merged 2 commits into from
Apr 25, 2026
Merged

fix(ux): replace %w with %v in log format strings #129

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f61b1cd
fix(ux): replace %w with %v in log format strings
skevetter Apr 25, 2026
ab04e0f
fix(ux): replace %w with %v in log.Debugf format strings
skevetter Apr 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cmd/ssh.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -798,7 +798,7 @@ func startSSHKeepAlive(
case <-ticker.C:
_, _, err := client.SendRequest("keepalive@openssh.com", true, nil)
if err != nil {
log.Errorf("Failed to send keepalive: %w", err)
log.Errorf("Failed to send keepalive: %v", err)
}
}
}
Expand Down
2 changes: 1 addition & 1 deletion pkg/daemon/platform/local_server.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -603,7 +603,7 @@ func (l *localServer) watchWorkspaces(
fmt.Errorf("failed to watch workspaces: %w", err).Error(),
http.StatusInternalServerError,
)
log.Errorf("watch workspaces: %w", err)
log.Errorf("watch workspaces: %v", err)
return
}
}
Expand Down
2 changes: 1 addition & 1 deletion pkg/loftconfig/client.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ func GetDevsyConfig(context, provider string, port int) (*client.Config, error)

rawJson, err := json.Marshal(request)
if err != nil {
log.Errorf("Error parsing request: %w", err)
log.Errorf("Error parsing request: %v", err)
return nil, err
}

Expand Down
4 changes: 2 additions & 2 deletions pkg/loftconfig/config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ func AuthDevsyCliToPlatform(config *client.Config) error {
out, err := cmd.CombinedOutput()
if err != nil {
log.Debugf(
"Failed executing `%s pro login`: %w, output: %s",
"Failed executing `%s pro login`: %v, output: %s",
pkgconfig.BinaryName,
err,
out,
Expand All @@ -47,7 +47,7 @@ func AuthVClusterCliToPlatform(config *client.Config) error {
cmd := exec.Command("vcluster", "login", "--access-key", config.AccessKey, config.Host)
out, err := cmd.CombinedOutput()
if err != nil {
log.Debugf("Failed executing `vcluster login` : %w, output: %s", err, out)
log.Debugf("Failed executing `vcluster login` : %v, output: %s", err, out)
return fmt.Errorf("error executing 'vcluster login' command: %w", err)
}

Expand Down
Loading