feat(config): add securityOpt passthrough to container create#169
Merged
Conversation
Wire securityOpt from devcontainer.json through to docker run as --security-opt flags. The dockerless code path was missing this field. Add unit tests for the security opt arg assembly and an E2E test validating securityOpt on docker containers.
✅ Deploy Preview for devsydev canceled.
|
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
📝 WalkthroughWalkthroughThis PR extends devcontainer support to honor Docker security options ( ChangesDocker Security Options Support
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Review rate limit: 0/1 reviews remaining, refill in 60 minutes.Comment |
skevetter
marked this pull request as ready for review
May 3, 2026 06:19
This was referenced May 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
securityOptvalues fromdevcontainer.jsonthrough todocker runas--security-optflagsSecurityOptfield in the dockerless container creation path (getDockerlessRunOptions)seccomp=unconfinedandapparmor=unconfinedapplied to containerSummary by CodeRabbit
Release Notes
New Features
Tests