Skip to content

feat(feature): add OCI pull retry with URL sanitization#176

Merged
skevetter merged 2 commits into
mainfrom
d226/oci-retry
May 3, 2026
Merged

feat(feature): add OCI pull retry with URL sanitization#176
skevetter merged 2 commits into
mainfrom
d226/oci-retry

Conversation

@skevetter

Copy link
Copy Markdown
Contributor

Summary

  • Add retry logic (3 attempts with 1s/2s/4s exponential backoff) to OCI feature image pulls, only retrying on transient errors (5xx, network failures) — not on 4xx
  • Sanitize registry URLs in all error messages to show hostname only (e.g. ghcr.io instead of full path)
  • Extract pullOCIImage helper to keep function complexity under the linter threshold

Add retry logic (3 attempts, exponential backoff) to OCI feature pulls
so transient registry failures don't break workspace creation. Strip
registry URLs to hostname-only in error messages to avoid exposing
internal paths.
@netlify

netlify Bot commented May 3, 2026

Copy link
Copy Markdown

Deploy Preview for devsydev canceled.

Name Link
🔨 Latest commit 6ae8131
🔍 Latest deploy log https://app.netlify.com/projects/devsydev/deploys/69f740e6e95e8f00084400c4

@coderabbitai

coderabbitai Bot commented May 3, 2026

Copy link
Copy Markdown

Warning

Rate limit exceeded

@skevetter has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 30 minutes and 40 seconds before requesting another review.

To keep reviews running without waiting, you can enable usage-based add-on for your organization. This allows additional reviews beyond the hourly cap. Account admins can enable it under billing.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 186497d6-9a1b-4698-bbd0-62a787440398

📥 Commits

Reviewing files that changed from the base of the PR and between 11158bb and 6ae8131.

📒 Files selected for processing (8)
  • cmd/up.go
  • pkg/devcontainer/build/options_test.go
  • pkg/devcontainer/feature/features.go
  • pkg/devcontainer/feature/features_oci_test.go
  • pkg/devcontainer/feature/oci_retry.go
  • pkg/devcontainer/feature/oci_retry_test.go
  • pkg/devcontainer/feature/sanitize.go
  • pkg/devcontainer/feature/sanitize_test.go

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
Review rate limit: 0/1 reviews remaining, refill in 30 minutes and 40 seconds.

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions Bot added the size/l label May 3, 2026
@skevetter
skevetter marked this pull request as ready for review May 3, 2026 12:05
@skevetter
skevetter enabled auto-merge (squash) May 3, 2026 12:05
Move exported Run method before unexported methods in cmd/up.go to fix
funcorder violations. Extract pullAndExtractOCIFeature helper to reduce
processOCIFeature cyclomatic complexity. Add testOtherCacheImage constant
to fix goconst violation in options_test.go.
@skevetter
skevetter merged commit bce287e into main May 3, 2026
51 checks passed
@skevetter
skevetter deleted the d226/oci-retry branch May 3, 2026 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant