Skip to content

feat(config): support array form for extends property - #188

Merged
skevetter merged 1 commit into
mainfrom
f39b/extends-array
May 4, 2026
Merged

feat(config): support array form for extends property#188
skevetter merged 1 commit into
mainfrom
f39b/extends-array

Conversation

@skevetter

Copy link
Copy Markdown
Contributor

Summary

  • The extends field now accepts both "path.json" (string) and ["a.json", "b.json"] (array) forms via a custom ExtendsRef type with JSON marshal/unmarshal
  • Array refs are resolved left-to-right: each parent is merged on top of the previous, then the child config is merged last
  • Includes unit tests for array single-ref, multi-ref, ordering semantics, cycle detection through array, and ExtendsRef marshal/unmarshal
  • Adds E2E test validating array extends with read-configuration

The extends field now accepts both a single string and an array of
strings. Array refs are resolved left-to-right with later entries
overriding earlier ones, then the child config is merged on top.
@netlify

netlify Bot commented May 3, 2026

Copy link
Copy Markdown

Deploy Preview for devsydev canceled.

Name Link
🔨 Latest commit b9bb8ae
🔍 Latest deploy log https://app.netlify.com/projects/devsydev/deploys/69f7dfbeaa0f90000800a076

@coderabbitai

coderabbitai Bot commented May 3, 2026

Copy link
Copy Markdown

Warning

Rate limit exceeded

@skevetter has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 49 minutes and 42 seconds before requesting another review.

To keep reviews running without waiting, you can enable usage-based add-on for your organization. This allows additional reviews beyond the hourly cap. Account admins can enable it under billing.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 8eb615a5-57a2-4412-95c8-6b92f7e60082

📥 Commits

Reviewing files that changed from the base of the PR and between b51dbf6 and b9bb8ae.

📒 Files selected for processing (8)
  • e2e/tests/extends/extends.go
  • e2e/tests/extends/testdata/array-extends/.devcontainer/base.json
  • e2e/tests/extends/testdata/array-extends/.devcontainer/devcontainer.json
  • e2e/tests/extends/testdata/array-extends/.devcontainer/middleware.json
  • pkg/devcontainer/config/config.go
  • pkg/devcontainer/config/extends.go
  • pkg/devcontainer/config/extends_test.go
  • pkg/devcontainer/config/parse.go

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
Review rate limit: 0/1 reviews remaining, refill in 49 minutes and 42 seconds.

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions Bot added the size/l label May 3, 2026
@skevetter
skevetter merged commit da42f37 into main May 4, 2026
94 of 96 checks passed
@skevetter
skevetter deleted the f39b/extends-array branch May 4, 2026 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant