Skip to content

feat(cli): add --docker-path flag to read-configuration command#245

Merged
skevetter merged 1 commit into
mainfrom
4f40-fc1b-ws-read-config-container
May 6, 2026
Merged

feat(cli): add --docker-path flag to read-configuration command#245
skevetter merged 1 commit into
mainfrom
4f40-fc1b-ws-read-config-container

Conversation

@skevetter

Copy link
Copy Markdown
Contributor

Summary

Adds --docker-path flag to the read-configuration command, allowing users to specify a custom docker/podman executable path when reading configuration from a running container via --container-id. Previously the command hardcoded "docker" as the container runtime binary. This aligns read-configuration with the exec command which already supports --docker-path.

Per the devcontainer CLI reference spec, the read-configuration command supports --docker-path as an optional flag for specifying the Docker CLI path (or Docker-compatible CLI) to use.

Changes:

  • Added DockerPath field to ReadConfigurationCmd struct
  • Registered --docker-path flag in NewReadConfigurationCmd() following the same pattern as cmd/exec.go
  • Updated resolveConfigFromContainer() to use the custom docker path when specified (defaults to "docker" if empty)
  • Added E2E tests: nonexistent container error, container without metadata label, valid --docker-path usage, and invalid --docker-path error

@netlify

netlify Bot commented May 6, 2026

Copy link
Copy Markdown

Deploy Preview for devsydev canceled.

Name Link
🔨 Latest commit a1c589c
🔍 Latest deploy log https://app.netlify.com/projects/devsydev/deploys/69fb20fe7d07bf0008eaac7b

@coderabbitai

coderabbitai Bot commented May 6, 2026

Copy link
Copy Markdown

Warning

Rate limit exceeded

@skevetter has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 6 minutes and 18 seconds before requesting another review.

To continue reviewing without waiting, purchase usage credits in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: d95e466e-81a3-4e67-957e-97b331edb1de

📥 Commits

Reviewing files that changed from the base of the PR and between 271f84e and a1c589c.

📒 Files selected for processing (2)
  • cmd/readconfiguration.go
  • e2e/tests/readconfiguration/readconfiguration.go

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions Bot added the size/m label May 6, 2026
Allow users to specify a custom docker/podman executable path when
reading configuration from a running container via --container-id.
Previously the command hardcoded "docker" — this aligns it with
the exec command which already supports --docker-path.
@skevetter
skevetter force-pushed the 4f40-fc1b-ws-read-config-container branch from cd4b750 to a1c589c Compare May 6, 2026 11:07
@skevetter
skevetter enabled auto-merge (squash) May 6, 2026 11:07
@skevetter
skevetter merged commit 7e53991 into main May 6, 2026
54 checks passed
@skevetter
skevetter deleted the 4f40-fc1b-ws-read-config-container branch May 6, 2026 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant