Skip to content

feat(cli): rewrite set-up command to full devcontainer spec compliance #251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
skevetter merged 5 commits into from
May 6, 2026
Merged

feat(cli): rewrite set-up command to full devcontainer spec compliance #251

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
09fc864
feat(cli): rewrite set-up command to full devcontainer spec compliance
skevetter May 6, 2026
b66993d
fix: use resolved remote user in feature staging and remove host-CWD …
skevetter May 6, 2026
2496e9d
fix: resolve goconst lint errors in setup command
skevetter May 6, 2026
ee4d6ff
fix: consolidate hook name constants to resolve goconst lint violations
skevetter May 6, 2026
cbb0ce4
fix: extract testCmdHello constant to resolve goconst lint on "hello"
skevetter May 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions cmd/exec_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ func TestValidateRemoteEnv_EmptyKey(t *testing.T) {

func TestNewExecCmd_RequiresWorkspaceFolderOrContainerID(t *testing.T) {
execCmd := NewExecCmd(&flags.GlobalFlags{})
execCmd.SetArgs([]string{"--", "echo", "hello"})
execCmd.SetArgs([]string{"--", testCmdEcho, testCmdHello})
err := execCmd.Execute()
require.Error(t, err)
assert.Contains(t, err.Error(), "either --workspace-folder or --container-id must be provided")
Expand Down Expand Up @@ -97,7 +97,7 @@ func TestExecCmd_NonExistentContainerID(t *testing.T) {
GlobalFlags: &flags.GlobalFlags{},
ContainerID: "nonexistent-container-id-12345",
}
err := cmd.runWithContainerID(t.Context(), []string{"echo", "hello"})
err := cmd.runWithContainerID(t.Context(), []string{testCmdEcho, testCmdHello})
require.Error(t, err)
assert.Contains(t, err.Error(), "nonexistent-container-id-12345")
}
Expand Down
5 changes: 0 additions & 5 deletions cmd/runusercommands_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,11 +13,6 @@ const (
flagContainerID = "--container-id"
testContainerID = "abc"
testContainerIDHex = "abc123"
hookOnCreate = "onCreateCommand"
hookUpdateContent = "updateContentCommand"
hookPostCreate = "postCreateCommand"
hookPostStart = "postStartCommand"
hookPostAttach = "postAttachCommand"
)

func TestNewRunUserCommandsCmd_CommandName(t *testing.T) {
Expand Down
Loading
Loading