Skip to content

test(e2e): expand Podman provider test coverage #280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
skevetter merged 1 commit into from
May 14, 2026
Merged

test(e2e): expand Podman provider test coverage #280

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
294 changes: 273 additions & 21 deletions e2e/tests/up/provider_podman.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,11 @@ import (
"context"
"os"
"os/exec"
"strings"

"github.com/devsy-org/devsy/e2e/framework"
"github.com/onsi/ginkgo/v2"
"github.com/onsi/gomega"
)

var _ = ginkgo.Describe(
Expand All @@ -30,17 +32,142 @@ var _ = ginkgo.Describe(
framework.ExpectNoError(err)
})

ginkgo.It(
"should start a new workspace with existing image",
func(ctx context.Context) {
tempDir, err := setupWorkspace("tests/up/testdata/docker", initialDir, f)
framework.ExpectNoError(err)
ginkgo.Context("basic", func() {
ginkgo.It(
"should start a new workspace with existing image",
func(ctx context.Context) {
tempDir, err := setupWorkspace("tests/up/testdata/docker", initialDir, f)
framework.ExpectNoError(err)

err = f.DevsyUp(ctx, tempDir)
framework.ExpectNoError(err)
},
ginkgo.SpecTimeout(framework.TimeoutShort()),
)
err = f.DevsyUp(ctx, tempDir)
framework.ExpectNoError(err)
},
ginkgo.SpecTimeout(framework.TimeoutShort()),
)
})

ginkgo.Context("build", func() {
ginkgo.It(
"should start a workspace with a multistage Dockerfile build",
func(ctx context.Context) {
tempDir, err := setupWorkspace(
"tests/up/testdata/docker-with-multi-stage-build",
initialDir,
f,
)
framework.ExpectNoError(err)

err = f.DevsyUp(ctx, tempDir)
framework.ExpectNoError(err)
},
ginkgo.SpecTimeout(framework.TimeoutLong()),
)

ginkgo.It(
"should build and respect overrideCommand false",
func(ctx context.Context) {
tempDir, err := setupWorkspace(
"tests/up/testdata/docker-override-command-false",
initialDir,
f,
)
framework.ExpectNoError(err)

err = f.DevsyUp(ctx, tempDir)
framework.ExpectNoError(err)
},
ginkgo.SpecTimeout(framework.TimeoutShort()),
)
})

ginkgo.Context("lifecycle commands", func() {
ginkgo.It(
"should run postCreateCommand with object syntax",
func(ctx context.Context) {
tempDir, err := setupWorkspace(
"tests/up/testdata/docker-postcreate-parallel",
initialDir,
f,
)
framework.ExpectNoError(err)

err = f.DevsyUp(ctx, tempDir)
framework.ExpectNoError(err)

one, err := f.DevsySSH(ctx, tempDir, "cat /tmp/post-create-one.out")
framework.ExpectNoError(err)
gomega.Expect(strings.TrimSpace(one)).To(gomega.Equal("postCreateOne"))

two, err := f.DevsySSH(ctx, tempDir, "cat /tmp/post-create-two.out")
framework.ExpectNoError(err)
gomega.Expect(strings.TrimSpace(two)).To(gomega.Equal("postCreateTwo"))
},
ginkgo.SpecTimeout(framework.TimeoutShort()),
)
})

ginkgo.Context("agent delivery", func() {
ginkgo.It(
"should deliver the agent binary and execute SSH commands",
func(ctx context.Context) {
tempDir, err := setupWorkspace("tests/up/testdata/docker", initialDir, f)
framework.ExpectNoError(err)

err = f.DevsyUp(ctx, tempDir)
framework.ExpectNoError(err)

err = f.DevsySSHEchoTestString(ctx, tempDir)
framework.ExpectNoError(err)
},
ginkgo.SpecTimeout(framework.TimeoutShort()),
)
})

ginkgo.Context("exec", func() {
ginkgo.It(
"should execute commands inside the container via SSH",
func(ctx context.Context) {
tempDir, err := setupWorkspace("tests/up/testdata/docker", initialDir, f)
framework.ExpectNoError(err)

err = f.DevsyUp(ctx, tempDir)
framework.ExpectNoError(err)

out, err := f.DevsySSH(ctx, tempDir, "echo -n hello-podman")
framework.ExpectNoError(err)
framework.ExpectEqual(out, "hello-podman")

out, err = f.DevsySSH(ctx, tempDir, "pwd")
framework.ExpectNoError(err)
gomega.Expect(strings.TrimSpace(out)).NotTo(gomega.BeEmpty())
},
ginkgo.SpecTimeout(framework.TimeoutShort()),
)
})

ginkgo.Context("cleanup", func() {
ginkgo.It(
"should delete workspace and clean up resources",
func(ctx context.Context) {
tempDir, err := framework.CopyToTempDir("tests/up/testdata/docker")
framework.ExpectNoError(err)
ginkgo.DeferCleanup(framework.CleanupTempDir, initialDir, tempDir)

err = f.DevsyUp(ctx, tempDir)
framework.ExpectNoError(err)

_, err = f.FindWorkspace(ctx, tempDir)
framework.ExpectNoError(err)

err = f.DevsyWorkspaceDelete(ctx, tempDir)
framework.ExpectNoError(err)

_, err = f.FindWorkspace(ctx, tempDir)
framework.ExpectError(err)
},
ginkgo.SpecTimeout(framework.TimeoutShort()),
)
})
})

ginkgo.Context("with rootful podman", func() {
Expand All @@ -59,7 +186,7 @@ var _ = ginkgo.Describe(
err = wrapper.Close()
framework.ExpectNoError(err)

// #nosec G302 -- TODO Consider using a more secure permission setting and ownership if needed.
// #nosec G302 -- wrapper script needs execute permission
err = os.Chmod(initialDir+"/bin/podman-rootful", 0o755)
framework.ExpectNoError(err)

Expand All @@ -74,17 +201,142 @@ var _ = ginkgo.Describe(
framework.ExpectNoError(err)
})

ginkgo.It(
"should start a new workspace with existing image",
func(ctx context.Context) {
tempDir, err := setupWorkspace("tests/up/testdata/docker", initialDir, f)
framework.ExpectNoError(err)
ginkgo.Context("basic", func() {
ginkgo.It(
"should start a new workspace with existing image",
func(ctx context.Context) {
tempDir, err := setupWorkspace("tests/up/testdata/docker", initialDir, f)
framework.ExpectNoError(err)

err = f.DevsyUp(ctx, tempDir)
framework.ExpectNoError(err)
},
ginkgo.SpecTimeout(framework.TimeoutShort()),
)
err = f.DevsyUp(ctx, tempDir)
framework.ExpectNoError(err)
},
ginkgo.SpecTimeout(framework.TimeoutShort()),
)
})

ginkgo.Context("build", func() {
ginkgo.It(
"should start a workspace with a multistage Dockerfile build",
func(ctx context.Context) {
tempDir, err := setupWorkspace(
"tests/up/testdata/docker-with-multi-stage-build",
initialDir,
f,
)
framework.ExpectNoError(err)

err = f.DevsyUp(ctx, tempDir)
framework.ExpectNoError(err)
},
ginkgo.SpecTimeout(framework.TimeoutLong()),
)

ginkgo.It(
"should build and respect overrideCommand false",
func(ctx context.Context) {
tempDir, err := setupWorkspace(
"tests/up/testdata/docker-override-command-false",
initialDir,
f,
)
framework.ExpectNoError(err)

err = f.DevsyUp(ctx, tempDir)
framework.ExpectNoError(err)
},
ginkgo.SpecTimeout(framework.TimeoutShort()),
)
})

ginkgo.Context("lifecycle commands", func() {
ginkgo.It(
"should run postCreateCommand with object syntax",
func(ctx context.Context) {
tempDir, err := setupWorkspace(
"tests/up/testdata/docker-postcreate-parallel",
initialDir,
f,
)
framework.ExpectNoError(err)

err = f.DevsyUp(ctx, tempDir)
framework.ExpectNoError(err)

one, err := f.DevsySSH(ctx, tempDir, "cat /tmp/post-create-one.out")
framework.ExpectNoError(err)
gomega.Expect(strings.TrimSpace(one)).To(gomega.Equal("postCreateOne"))

two, err := f.DevsySSH(ctx, tempDir, "cat /tmp/post-create-two.out")
framework.ExpectNoError(err)
gomega.Expect(strings.TrimSpace(two)).To(gomega.Equal("postCreateTwo"))
},
ginkgo.SpecTimeout(framework.TimeoutShort()),
)
})

ginkgo.Context("agent delivery", func() {
ginkgo.It(
"should deliver the agent binary and execute SSH commands",
func(ctx context.Context) {
tempDir, err := setupWorkspace("tests/up/testdata/docker", initialDir, f)
framework.ExpectNoError(err)

err = f.DevsyUp(ctx, tempDir)
framework.ExpectNoError(err)

err = f.DevsySSHEchoTestString(ctx, tempDir)
framework.ExpectNoError(err)
},
ginkgo.SpecTimeout(framework.TimeoutShort()),
)
})

ginkgo.Context("exec", func() {
ginkgo.It(
"should execute commands inside the container via SSH",
func(ctx context.Context) {
tempDir, err := setupWorkspace("tests/up/testdata/docker", initialDir, f)
framework.ExpectNoError(err)

err = f.DevsyUp(ctx, tempDir)
framework.ExpectNoError(err)

out, err := f.DevsySSH(ctx, tempDir, "echo -n hello-podman")
framework.ExpectNoError(err)
framework.ExpectEqual(out, "hello-podman")

out, err = f.DevsySSH(ctx, tempDir, "pwd")
framework.ExpectNoError(err)
gomega.Expect(strings.TrimSpace(out)).NotTo(gomega.BeEmpty())
},
ginkgo.SpecTimeout(framework.TimeoutShort()),
)
})

ginkgo.Context("cleanup", func() {
ginkgo.It(
"should delete workspace and clean up resources",
func(ctx context.Context) {
tempDir, err := framework.CopyToTempDir("tests/up/testdata/docker")
framework.ExpectNoError(err)
ginkgo.DeferCleanup(framework.CleanupTempDir, initialDir, tempDir)

err = f.DevsyUp(ctx, tempDir)
framework.ExpectNoError(err)

_, err = f.FindWorkspace(ctx, tempDir)
framework.ExpectNoError(err)

err = f.DevsyWorkspaceDelete(ctx, tempDir)
framework.ExpectNoError(err)

_, err = f.FindWorkspace(ctx, tempDir)
framework.ExpectError(err)
},
ginkgo.SpecTimeout(framework.TimeoutShort()),
)
})
})
},
)
Loading