fix(ci): correct RC tag regex to match dot-separated format#329
Closed
skevetter wants to merge 1 commit into
Closed
fix(ci): correct RC tag regex to match dot-separated format#329skevetter wants to merge 1 commit into
skevetter wants to merge 1 commit into
Conversation
✅ Deploy Preview for devsydev canceled.
|
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
Author
|
Closing duplicate — PR #328 covers the same fix and is already in CI. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
promote-release.ymlworkflow validated RC tags with the regex-rc[0-9]+$, which expected a format likev1.3.0-rc4. However, release-please produces tags in the formatv1.3.0-rc.4(with a dot betweenrcand the number), causing the validation step to reject all valid RC tags.This PR fixes the regex to
-rc\.[0-9]+$to match the actual release-please tag format, and updates the description example fromv1.1.0-rc1tov1.3.0-rc.1to reflect the correct format.