fix(ide): make browser IDE workspace launch non-blocking and lifecycle-aware#436

Merged

skevetter merged 23 commits into

mainfrom

fix/vscode-browser-launch-detection

May 26, 2026

Commits on May 26, 2026

fix(ide): make browser IDE workspace launch non-blocking and lifecycle-aware
skevetter
committed
fix(e2e): use --ide-option OPEN=false to exercise browser tunnel path
skevetter
committed
fix(e2e): allow empty RemoteWorkspaceFolder in browser envelope test
skevetter
committed
refactor(opener,tunnel): pass ctx positionally, rename Params→IdeParams
skevetter
committed
refactor(opener): bundle label+openBrowser into browserIDEInvocation struct
skevetter
committed
fix(opener): annotate intentional context.Background() in openBrowserAsync
skevetter
committed
fix(opener): satisfy gosec G118 with context.WithoutCancel for async browser open
skevetter
committed
fix(opener,delete,helper): address CodeRabbit review
skevetter
committed
refactor(opener,helper): extract helpers to satisfy cyclop lint
skevetter
committed
fix(opener): serialize KillBrowserTunnel with the workspace tunnel.lock
skevetter
committed
ci: cancel in-flight PR runs on new pushes
skevetter
committed
refactor(opener): rename isOurHelper -> helperMatchesState
skevetter
committed
style(comments): drop first-person plural from comments added in this branch
skevetter
committed
test(e2e): fold browser envelope check into up-behaviors
skevetter
committed
style(opener): drop gopsutil from user-facing log + doc comments
skevetter
committed
fix(opener,helper): land final review findings (silent failures + fd leak)
skevetter
committed
fix(opener): land final cleanups + add e2e and unit tests
skevetter
committed
refactor(opener,ssh,delete): land remaining review items (tests, API, imports, file split)
skevetter
committed
docs(opener,ssh): fix godoc misattachment + tighten KillBrowserTunnel doc
skevetter
committed
fix(opener): lint regressions (cyclop + goconst)
skevetter
committed
ci: re-trigger after stuck windows post-setup step
skevetter
committed
fix(up,opener): unify envelope timing + refresh IsBrowserIDE doc
skevetter
committed
fix(helper): reject stdio fds and empty host in --inherit-listener
skevetter
committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(ide): make browser IDE workspace launch non-blocking and lifecycle-aware#436

fix(ide): make browser IDE workspace launch non-blocking and lifecycle-aware#436
skevetter merged 23 commits into
mainfrom
fix/vscode-browser-launch-detection

Commits on May 26, 2026

fix(ide): make browser IDE workspace launch non-blocking and lifecycle-aware

fix(e2e): use --ide-option OPEN=false to exercise browser tunnel path

fix(e2e): allow empty RemoteWorkspaceFolder in browser envelope test

refactor(opener,tunnel): pass ctx positionally, rename Params→IdeParams

refactor(opener): bundle label+openBrowser into browserIDEInvocation struct

fix(opener): annotate intentional context.Background() in openBrowserAsync

fix(opener): satisfy gosec G118 with context.WithoutCancel for async browser open

fix(opener,delete,helper): address CodeRabbit review

refactor(opener,helper): extract helpers to satisfy cyclop lint

fix(opener): serialize KillBrowserTunnel with the workspace tunnel.lock

ci: cancel in-flight PR runs on new pushes

refactor(opener): rename isOurHelper -> helperMatchesState

style(comments): drop first-person plural from comments added in this branch

test(e2e): fold browser envelope check into up-behaviors

style(opener): drop gopsutil from user-facing log + doc comments

fix(opener,helper): land final review findings (silent failures + fd leak)

fix(opener): land final cleanups + add e2e and unit tests

refactor(opener,ssh,delete): land remaining review items (tests, API, imports, file split)

docs(opener,ssh): fix godoc misattachment + tighten KillBrowserTunnel doc

fix(opener): lint regressions (cyclop + goconst)

ci: re-trigger after stuck windows post-setup step

fix(up,opener): unify envelope timing + refresh IsBrowserIDE doc

fix(helper): reject stdio fds and empty host in --inherit-listener