Skip to content

fix(desktop): increase workspace launch watchdog to 10 minutes #453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
skevetter merged 1 commit into from
May 27, 2026
Merged

fix(desktop): increase workspace launch watchdog to 10 minutes #453

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions desktop/src/renderer/src/lib/components/workspace/WorkspaceWizard.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ const TEMPLATES = [
{ name: "Ruby", source: "https://github.com/skevetter/devsy-quickstart-ruby" },
]

const LAUNCH_TIMEOUT_MS = 5 * 60 * 1000
const LAUNCH_TIMEOUT_MS = 10 * 60 * 1000

let {
open = $bindable(false),
Expand Down Expand Up @@ -314,7 +314,7 @@ async function handleLaunch() {
if (launchRunning) {
launchRunning = false
launchError =
"Workspace creation timed out after 5 minutes. The process may still be running in the background."
"Workspace creation timed out after 10 minutes. The process may still be running in the background."
toasts.error(launchError)
unlisten?.()
unlisten = null
Expand Down
14 changes: 7 additions & 7 deletions desktop/src/renderer/src/lib/components/workspace/WorkspaceWizard.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -393,7 +393,7 @@ describe("launch watchdog", () => {
document.body.innerHTML = ""
})

it("fires after 5 minutes when no done event arrives", async () => {
it("fires after 10 minutes when no done event arrives", async () => {
providers.set([makeProvider("docker")])
const { getByText, queryByText, unmount } = render(WorkspaceWizard, {
props: { open: true },
Expand All @@ -407,11 +407,11 @@ describe("launch watchdog", () => {
await fireEvent.click(launchBtn)
await flushAsync()

// Advance past the 5-minute watchdog.
await vi.advanceTimersByTimeAsync(5 * 60 * 1000 + 1)
// Advance past the 10-minute watchdog.
await vi.advanceTimersByTimeAsync(10 * 60 * 1000 + 1)
await flushAsync()

expect(queryByText(/timed out after 5 minutes/i)).not.toBeNull()
expect(queryByText(/timed out after 10 minutes/i)).not.toBeNull()
expect(queryByText("Open Workspace")).toBeNull()
expect(queryByText("Retry")).not.toBeNull()
unmount()
Expand All @@ -432,10 +432,10 @@ describe("launch watchdog", () => {
await flushAsync()

// Trip the watchdog.
await vi.advanceTimersByTimeAsync(5 * 60 * 1000 + 1)
await vi.advanceTimersByTimeAsync(10 * 60 * 1000 + 1)
await flushAsync()

expect(queryByText(/timed out after 5 minutes/i)).not.toBeNull()
expect(queryByText(/timed out after 10 minutes/i)).not.toBeNull()

// Late done event (the listener should have been disposed, so this is a no-op).
progressCallback?.({
Expand All @@ -446,7 +446,7 @@ describe("launch watchdog", () => {
await flushAsync()

// Timeout error is still visible; Open Workspace did not appear.
expect(queryByText(/timed out after 5 minutes/i)).not.toBeNull()
expect(queryByText(/timed out after 10 minutes/i)).not.toBeNull()
expect(queryByText("Open Workspace")).toBeNull()
unmount()
})
Expand Down
Loading