Skip to content

fix(desktop): open provider overlay sheet from command palette #481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
skevetter merged 1 commit into from
Jun 4, 2026
Merged

fix(desktop): open provider overlay sheet from command palette #481

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions desktop/src/renderer/src/App.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@ import WorkspacesPage from "./pages/WorkspacesPage.svelte"
import WorkspaceDetailPage from "./pages/WorkspaceDetailPage.svelte"
import ProvidersPage from "./pages/ProvidersPage.svelte"
import ProviderAddPage from "./pages/ProviderAddPage.svelte"
import ProviderDetailPage from "./pages/ProviderDetailPage.svelte"
import MachinesPage from "./pages/MachinesPage.svelte"
import MachineDetailPage from "./pages/MachineDetailPage.svelte"
import ContextsPage from "./pages/ContextsPage.svelte"
Expand All @@ -44,7 +43,7 @@ const routes = {
"/workspaces/:id": WorkspaceDetailPage,
"/providers": ProvidersPage,
"/providers/add": ProviderAddPage,
"/providers/:id": ProviderDetailPage,
"/providers/:id": ProvidersPage,
"/machines": MachinesPage,
"/machines/:id": MachineDetailPage,
"/contexts": ContextsPage,
Expand Down
11 changes: 5 additions & 6 deletions desktop/src/renderer/src/lib/components/provider/ProviderCard.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,13 @@
import { badgeVariants } from "$lib/components/ui/badge/index.js"
import { Star } from "@lucide/svelte"
import ProviderIcon from "./ProviderIcon.svelte"
import ProviderSheet from "./ProviderSheet.svelte"
import { providerVersions } from "$lib/stores/providerVersions.js"
import type { Provider } from "$lib/types/index.js"

let { provider }: { provider: Provider } = $props()
let sheetOpen = $state(false)
let {
provider,
onopen,
}: { provider: Provider; onopen?: () => void } = $props()

function sourceDisplay(p: Provider): string {
if (p.source?.github) return p.source.github
Expand All @@ -20,7 +21,7 @@ function sourceDisplay(p: Provider): string {
<button
type="button"
class="rounded-xl border bg-card p-6 text-left text-card-foreground shadow-sm transition-colors hover:bg-accent/50 w-full relative"
onclick={() => (sheetOpen = true)}
onclick={() => onopen?.()}
>
{#if $providerVersions.updates[provider.name]?.updateAvailable}
<span
Expand Down Expand Up @@ -59,5 +60,3 @@ function sourceDisplay(p: Provider): string {
<p class="mt-1 text-xs text-muted-foreground truncate">{sourceDisplay(provider)}</p>
{/if}
</button>

<ProviderSheet {provider} bind:open={sheetOpen} />
Loading
Loading