Skip to content

fix(desktop): capture context name before awaits in handleDelete #490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
skevetter merged 1 commit into from
Jun 5, 2026
Merged

fix(desktop): capture context name before awaits in handleDelete #490

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions desktop/src/renderer/src/lib/components/context/ContextSheet.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,10 +89,13 @@ let confirmDeleteOpen = $state(false)

async function handleDelete() {
deleting = true
// Capture before awaits: refreshContexts() can null out the reactive
// `context` prop once this context is removed from the store.
const name = context.name
try {
await contextDelete(context.name)
await contextDelete(name)
await refreshContexts()
toasts.success(`Context "${context.name}" deleted`)
toasts.success(`Context "${name}" deleted`)
open = false
} catch (err) {
toasts.error(`Failed to delete context: ${extractErrorMessage(err)}`)
Expand Down
Loading