feat(ide): add vscode-web (code serve-web) browser IDE#532
Merged
Conversation
Adds the official "VS Code for the Web" as `--ide=vscode-web`, running the official VS Code CLI as `code serve-web`. Unlike openvscode (Gitpod fork, Open VSX) and code-server (Coder, Open VSX), this serves the full Microsoft Marketplace, so Microsoft-only extensions (Pylance, MS C/C++) are available. Wired through every layer that code-server uses, mirroring the one-package-per-browser-IDE convention: - config enum, ideparse registry, agent installIDE + async extension install - browser opener + tunnel label, SSH auth-sock reuse - desktop IDE pickers (Svelte) with a distinct browser-window icon Installs to ~/.vscode-web (distinct from the desktop vscode server's ~/.vscode-server), default port 10802, pinned VERSION (overridable). serve-web fetches its server payload on first connect, so the container needs outbound network access; this requirement is logged before launch.
The web/pro UI loads IDE icons from devsy.sh/assets. Asset must be uploaded there before the icon renders in that surface (desktop bundle already ships its own copy).
✅ Deploy Preview for images-devsy-sh canceled.
|
|
Warning Review limit reached
More reviews will be available in 43 minutes and 16 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more credits in the billing tab to continue. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits. 🚦 How do rate limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (5)
📝 WalkthroughWalkthroughAdds VS Code Web IDE support across config, parsing, backend setup, browser opening, desktop selection, and e2e coverage. Separately updates several email values to ChangesVS Code Web support
Contact email updates
Sequence Diagram(s)sequenceDiagram
participant SetupContainerCmd
participant VSCodeWebAsyncCmd
participant VSCodeWeb
SetupContainerCmd->>VSCodeWeb: Install()
SetupContainerCmd->>VSCodeWebAsyncCmd: start `vscode-web-async` with `--setup-info`
VSCodeWebAsyncCmd->>VSCodeWeb: InstallExtensions()
SetupContainerCmd->>VSCodeWeb: Start()
Estimated code review effort🎯 4 (Complex) | ⏱️ ~60 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
✅ Deploy Preview for devsydev canceled.
|
skevetter
marked this pull request as ready for review
June 26, 2026 14:18
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 5
🧹 Nitpick comments (2)
e2e/tests/ide/ide.go (1)
46-47: 🩺 Stability & Availability | 🔵 Trivial | 🏗️ Heavy liftThis smoke test stops short of the new browser-specific path.
With
--ide-launch=skip, Lines 46-47 only prove thatdevsy upaccepts--ide=vscode-web. The PR’s new risk is on first browser connect, whereserve-webfetches its payload, so opener/tunnel wiring and the outbound-network dependency can still regress unnoticed. Add one smoke step that actually opens the IDE or hits the tunneled URL after startup.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@e2e/tests/ide/ide.go` around lines 46 - 47, The smoke test in ide.go only verifies that DevsyUpWithIDE accepts --ide=vscode-web with --ide-launch=skip, but it never exercises the browser-specific startup path. Update the test around DevsyUpWithIDE and the subsequent assertion to actually open the IDE or request the tunneled serve-web URL after startup so the opener/tunnel wiring and outbound fetch path are covered. Use the existing DevsyUpWithIDE flow in this test to add a single post-startup browser-connect step and keep the no-error check on that interaction..golangci.yaml (1)
45-47: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winKeep the
duplsuppression narrower than the whole file.Excluding all of
cmd/internal/agentcontainer/setup.goturns off duplicate detection for unrelated setup paths too. A per-function//nolint:duplor a narrower exclusion keeps the intentional mirror code quiet without losing future signal elsewhere in the file.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In @.golangci.yaml around lines 45 - 47, The current dupl suppression in the golangci config is too broad because it disables duplicate detection for the entire setup.go file. Narrow the suppression by replacing the file-level exclusion with a per-function `//nolint:dupl` on the intentional mirrored code in the relevant setup function(s), or scope the exclusion to only the specific duplicated block so unrelated paths in `cmd/internal/agentcontainer/setup.go` still get checked.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@cmd/internal/agentcontainer/setup.go`:
- Around line 853-860: The VSCode Web setup is ignoring the configured bind
address and always hardcoding the listener in the NewVSCodeWeb ServerOptions.
Update the setup in setup.go to read and pass through the user-supplied
BIND_ADDRESS/ideOptions value instead of fixed 0.0.0.0 and the default port, and
ensure NewVSCodeWeb receives the actual bind target so it can honor the
configured address. Use the ServerOptions construction around NewVSCodeWeb and
the BIND_ADDRESS handling in vscodeweb.go as the key places to align.
In `@pkg/ide/opener/opener.go`:
- Around line 452-457: The shared browser IDE helper is still using
browserIDESpec.DefaultPort to populate ExtraPorts, so forwarded ports can
diverge from the parsed bind port exposed by BIND_ADDRESS. Update openBrowserIDE
to derive ExtraPorts from the parsed port value obtained from the bind address,
and ensure callers like the browser IDE path continue passing through the parsed
bind settings via browserIDESpec so auto-forwarding matches the browser URL.
- Around line 460-462: The TargetURLFn URL builder is inserting folder directly
into the query string, which breaks for paths containing spaces or reserved
characters. Update the TargetURLFn implementation to construct the URL with
net/url values (or at minimum apply url.QueryEscape to folder) so the folder
parameter is safely encoded before returning the VS Code Web URL.
In `@pkg/ide/vscodeweb/vscodeweb.go`:
- Around line 124-140: The install flow in vscodeweb.go currently short-circuits
in the install path by returning as soon as binaryPath(location) exists, which
prevents re-evaluating the requested release and prevents installSettings() from
being refreshed when Values change. Update the install logic around
v.installSettings, downloadAndExtract, and the binaryPath check so it either
keys installs off the selected release/version or detects config changes before
skipping, and ensure settings.json is rewritten whenever the desired workspace
or override settings differ from what is already installed.
- Around line 225-238: Sanitize or quote the config-supplied extension ID before
logging in the extension install loop in vscodeweb.go, since logging it verbatim
can allow newline-based log forging. Update all three call sites that reference
extension in this block—log.Info, log.Errorf, and log.Infof—so they use a
quoted/sanitized representation (for example via %q or an equivalent safe
formatter) while keeping the install command behavior unchanged.
---
Nitpick comments:
In @.golangci.yaml:
- Around line 45-47: The current dupl suppression in the golangci config is too
broad because it disables duplicate detection for the entire setup.go file.
Narrow the suppression by replacing the file-level exclusion with a per-function
`//nolint:dupl` on the intentional mirrored code in the relevant setup
function(s), or scope the exclusion to only the specific duplicated block so
unrelated paths in `cmd/internal/agentcontainer/setup.go` still get checked.
In `@e2e/tests/ide/ide.go`:
- Around line 46-47: The smoke test in ide.go only verifies that DevsyUpWithIDE
accepts --ide=vscode-web with --ide-launch=skip, but it never exercises the
browser-specific startup path. Update the test around DevsyUpWithIDE and the
subsequent assertion to actually open the IDE or request the tunneled serve-web
URL after startup so the opener/tunnel wiring and outbound fetch path are
covered. Use the existing DevsyUpWithIDE flow in this test to add a single
post-startup browser-connect step and keep the no-error check on that
interaction.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 247d5a4c-6fe7-4a36-81dd-979ace634af9
⛔ Files ignored due to path filters (1)
desktop/src/renderer/public/icons/ides/vscode-web.svgis excluded by!**/*.svg
📒 Files selected for processing (19)
.golangci.yamlSECURITY.mdcmd/internal/agentcontainer/container.gocmd/internal/agentcontainer/setup.gocmd/internal/agentcontainer/vscodeweb_async.gocmd/pro/start.godesktop/package.jsondesktop/src/renderer/src/lib/components/workspace/WorkspaceWizard.sveltedesktop/src/renderer/src/pages/SettingsPage.sveltedesktop/src/renderer/src/pages/WorkspaceDetailPage.sveltee2e/tests/ide/ide.gopkg/config/ide.gopkg/driver/kubernetes/pullsecrets.gopkg/ide/ideparse/parse.gopkg/ide/opener/browser_tunnel_state.gopkg/ide/opener/opener.gopkg/ide/types.gopkg/ide/vscodeweb/vscodeweb.gopkg/ide/vscodeweb/vscodeweb_test.go
Comment on lines
+853
to
+860
| vw := vscodeweb.NewVSCodeWeb(vscodeweb.ServerOptions{ | ||
| Extensions: vsCodeConfiguration.Extensions, | ||
| Settings: settings, | ||
| UserName: user, | ||
| Host: "0.0.0.0", | ||
| Port: strconv.Itoa(vscodeweb.DefaultVSCodeWebPort), | ||
| Values: ideOptions, | ||
| }) |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟠 Major | ⚡ Quick win
Honor BIND_ADDRESS instead of hardcoding the default listener.
pkg/ide/vscodeweb/vscodeweb.go exposes BIND_ADDRESS, but this path always passes 0.0.0.0:10802, and NewVSCodeWeb only uses Values for download selection. As written, any user-supplied bind address is ignored.
Suggested fix
+ host := "0.0.0.0"
+ port := strconv.Itoa(vscodeweb.DefaultVSCodeWebPort)
+ if bindAddr := vscodeweb.Options.GetValue(ideOptions, vscodeweb.BindAddressOption); bindAddr != "" {
+ parsedHost, parsedPort, err := net.SplitHostPort(bindAddr)
+ if err != nil {
+ return fmt.Errorf("parse %s: %w", vscodeweb.BindAddressOption, err)
+ }
+ host, port = parsedHost, parsedPort
+ }
+
vw := vscodeweb.NewVSCodeWeb(vscodeweb.ServerOptions{
Extensions: vsCodeConfiguration.Extensions,
Settings: settings,
UserName: user,
- Host: "0.0.0.0",
- Port: strconv.Itoa(vscodeweb.DefaultVSCodeWebPort),
+ Host: host,
+ Port: port,
Values: ideOptions,
})📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| vw := vscodeweb.NewVSCodeWeb(vscodeweb.ServerOptions{ | |
| Extensions: vsCodeConfiguration.Extensions, | |
| Settings: settings, | |
| UserName: user, | |
| Host: "0.0.0.0", | |
| Port: strconv.Itoa(vscodeweb.DefaultVSCodeWebPort), | |
| Values: ideOptions, | |
| }) | |
| host := "0.0.0.0" | |
| port := strconv.Itoa(vscodeweb.DefaultVSCodeWebPort) | |
| if bindAddr := vscodeweb.Options.GetValue(ideOptions, vscodeweb.BindAddressOption); bindAddr != "" { | |
| parsedHost, parsedPort, err := net.SplitHostPort(bindAddr) | |
| if err != nil { | |
| return fmt.Errorf("parse %s: %w", vscodeweb.BindAddressOption, err) | |
| } | |
| host, port = parsedHost, parsedPort | |
| } | |
| vw := vscodeweb.NewVSCodeWeb(vscodeweb.ServerOptions{ | |
| Extensions: vsCodeConfiguration.Extensions, | |
| Settings: settings, | |
| UserName: user, | |
| Host: host, | |
| Port: port, | |
| Values: ideOptions, | |
| }) |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@cmd/internal/agentcontainer/setup.go` around lines 853 - 860, The VSCode Web
setup is ignoring the configured bind address and always hardcoding the listener
in the NewVSCodeWeb ServerOptions. Update the setup in setup.go to read and pass
through the user-supplied BIND_ADDRESS/ideOptions value instead of fixed 0.0.0.0
and the default port, and ensure NewVSCodeWeb receives the actual bind target so
it can honor the configured address. Use the ServerOptions construction around
NewVSCodeWeb and the BIND_ADDRESS handling in vscodeweb.go as the key places to
align.
Comment on lines
+452
to
+457
| return openBrowserIDE(ctx, params, browserIDESpec{ | ||
| BindAddrOption: vscodeweb.Options.GetValue(ideOptions, vscodeweb.BindAddressOption), | ||
| DefaultPort: vscodeweb.DefaultVSCodeWebPort, | ||
| ForwardPorts: vscodeweb.Options.GetValue( | ||
| ideOptions, vscodeweb.ForwardPortsOption, | ||
| ) == config.BoolTrue, |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
Use the parsed bind port for forwarded ports.
This path exposes BIND_ADDRESS, but the shared openBrowserIDE helper still populates ExtraPorts from spec.DefaultPort instead of the parsed port. A config like 0.0.0.0:12345 will therefore target 12345 in the browser URL while auto-forwarding still registers 10802. Please switch the shared helper to use the parsed port before routing more IDEs through it.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@pkg/ide/opener/opener.go` around lines 452 - 457, The shared browser IDE
helper is still using browserIDESpec.DefaultPort to populate ExtraPorts, so
forwarded ports can diverge from the parsed bind port exposed by BIND_ADDRESS.
Update openBrowserIDE to derive ExtraPorts from the parsed port value obtained
from the bind address, and ensure callers like the browser IDE path continue
passing through the parsed bind settings via browserIDESpec so auto-forwarding
matches the browser URL.
…row dupl - url.QueryEscape the folder query param in browser IDE TargetURLFn so workspace paths with spaces/#/& open the correct folder (all 3 browser IDEs) - log extension IDs with %q to prevent CRLF log forging from config input - replace file-level dupl exclusion on setup.go with per-function //nolint:dupl on the intentionally-mirrored setupCodeServer/setupVSCodeWeb
Track the release URL used at install time in a .release marker and skip download only when the existing install matches. settings.json is now rewritten on every Install so workspace settings stay current after the first install. Adds marker round-trip and reinstall-detection tests. Addresses PR review (CodeRabbit #4).
skevetter
added a commit
that referenced
this pull request
Jun 26, 2026
The VS Code for the Web IDE (added in #532) references $WebsiteAssetsURL/vscode-web.svg; host the icon on assets.devsy.sh.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the official VS Code for the Web as
--ide=vscode-web, running the official VS Code CLI ascode serve-web.--ide=openvscodecode-servervscode-webThe motivation is the Microsoft Marketplace:
serve-webis the only browser option that serves Microsoft-only extensions (Pylance, MS C/C++), which the Open VSX-based IDEs can't.Design
Mirrors the established one-package-per-browser-IDE convention (
pkg/ide/codeserverwas the template). Wired through every layer code-server uses:pkg/config/ide.go—IDEVSCodeWebenumpkg/ide/vscodeweb/— new package (install/start/extensions), unit testscmd/internal/agentcontainer/—setupVSCodeWeb+vscode-web-asynccommandpkg/ide/ideparse— registry entrypkg/ide/opener— browser opener + tunnel labelpkg/ide/types.go— SSH auth-sock reusee2e/tests/ide/ide.go— smoke caseInstalls to
~/.vscode-web(distinct from the desktop vscode server's~/.vscode-server), default port10802, pinnedVERSION(overridable via the IDE option). Started with--without-connection-token --accept-server-license-termsso the background process never blocks.Notes for reviewers
code serve-webfetches its server payload on the first browser connect (inside the detached helper), so the container needs outbound access toupdate.code.visualstudio.com. This requirement is logged before launch, but a network-blocked container will fail at connect rather than at setup — worth confirming the failure mode is acceptable.devsy.sh/assets. The registry points atvscode-web.svg, which still needs to be uploaded there. The desktop bundle already ships its own copy.node_modulesabsent). The Svelte edits are trivial literal list additions; please confirmnpm run checkis clean in CI.vscode-webitself use Microsoft's official VS Code mark/builds, consistent with the existingvscode/vscodebrowserassets.Testing
go build ./...,go test ./pkg/ide/...(101 pass),golangci-lintclean of new issues. A scopedduplexclusion was added in.golangci.yamlfor the intentionally-parallel per-IDE*_async.go/ setup functions.Summary by CodeRabbit
New Features
Bug Fixes
Tests