Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions pkg/devcontainer/compose.go
Original file line number Diff line number Diff line change
Expand Up @@ -331,10 +331,6 @@ func (r *runner) finalizeComposeContainer(
return nil, fmt.Errorf("get image metadata from container: %w", err)
}

if err := r.updateContainerUserUID(ctx, parsedConfig); err != nil {
return nil, err
}

mergedConfig, err := mergeImageMetadataConfig(
ctx,
parsedConfig,
Expand All @@ -345,6 +341,11 @@ func (r *runner) finalizeComposeContainer(
return nil, err
}

resolvedConfig := withResolvedUser(parsedConfig.Config, mergedConfig)
if err := r.updateContainerUserUID(ctx, resolvedConfig); err != nil {
return nil, err
}

// expose the compose project name inside the container
if mergedConfig.RemoteEnv == nil {
mergedConfig.RemoteEnv = map[string]*string{}
Expand Down Expand Up @@ -372,7 +373,7 @@ func (r *runner) finalizeComposeContainer(
// updateContainerUserUID updates the container user's UID/GID on Docker drivers.
func (r *runner) updateContainerUserUID(
ctx context.Context,
parsedConfig *config.SubstitutedConfig,
parsedConfig *config.DevContainerConfig,
) error {
dockerDriver, ok := r.Driver.(driver.DockerDriver)
if !ok {
Expand All @@ -383,7 +384,7 @@ func (r *runner) updateContainerUserUID(
if err := dockerDriver.UpdateContainerUserUID(
ctx,
r.ID,
parsedConfig.Config,
parsedConfig,
writer,
); err != nil {
log.Errorf("failed to update container user UID/GID: error=%v", err)
Expand Down
17 changes: 16 additions & 1 deletion pkg/devcontainer/single.go
Original file line number Diff line number Diff line change
Expand Up @@ -534,7 +534,7 @@ func (r *runner) runContainer(
return dockerDriver.RunDockerDevContainer(ctx, &driver.RunDockerDevContainerParams{
WorkspaceID: r.ID,
Options: runOptions,
ParsedConfig: p.parsedConfig.Config,
ParsedConfig: withResolvedUser(p.parsedConfig.Config, mergedConfig),
IDE: r.WorkspaceConfig.Workspace.IDE.Name,
IDEOptions: r.WorkspaceConfig.Workspace.IDE.Options,
LocalWorkspaceFolder: r.LocalWorkspaceFolder,
Expand All @@ -546,6 +546,21 @@ func (r *runner) runContainer(
return r.Driver.RunDevContainer(ctx, r.ID, runOptions)
}

// withResolvedUser returns a copy of parsedConfig carrying the effective user
// identity from the merged config. remoteUser/containerUser/updateRemoteUserUID
// often come from image metadata rather than the raw devcontainer.json, so the
// container UID/GID remap must see the merged values or it silently skips.
func withResolvedUser(
parsedConfig *config.DevContainerConfig,
mergedConfig *config.MergedDevContainerConfig,
) *config.DevContainerConfig {
resolved := config.CloneDevContainerConfig(parsedConfig)
resolved.RemoteUser = mergedConfig.RemoteUser
resolved.ContainerUser = mergedConfig.ContainerUser
resolved.UpdateRemoteUserUID = mergedConfig.UpdateRemoteUserUID
return resolved
}

// parseWorkspaceMount parses the substituted workspace mount, returning nil when
// it has been suppressed via an empty workspaceMount.
func parseWorkspaceMount(substitutionContext *config.SubstitutionContext) *config.Mount {
Expand Down
29 changes: 29 additions & 0 deletions pkg/devcontainer/single_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -91,3 +91,32 @@ func TestWorkspaceMountDestination(t *testing.T) { //nolint:funlen // table-driv
})
}
}

func TestWithResolvedUser(t *testing.T) {
parsed := &config.DevContainerConfig{}
parsed.RunArgs = []string{"--cap-add=SYS_PTRACE"}

uid := true
merged := &config.MergedDevContainerConfig{}
merged.RemoteUser = "vscode"
merged.ContainerUser = "node"
merged.UpdateRemoteUserUID = &uid

got := withResolvedUser(parsed, merged)

if got.RemoteUser != "vscode" {
t.Errorf("RemoteUser = %q, want vscode", got.RemoteUser)
}
if got.ContainerUser != "node" {
t.Errorf("ContainerUser = %q, want node", got.ContainerUser)
}
if got.UpdateRemoteUserUID == nil || !*got.UpdateRemoteUserUID {
t.Errorf("UpdateRemoteUserUID = %v, want true", got.UpdateRemoteUserUID)
}
if len(got.RunArgs) != 1 || got.RunArgs[0] != "--cap-add=SYS_PTRACE" {
t.Errorf("RunArgs not preserved: %v", got.RunArgs)
}
if parsed.RemoteUser != "" {
t.Error("source config must not be mutated")
}
}
Loading