Skip to content

feat(desktop): clarify active state in create-workspace source selector#676

Merged
skevetter merged 2 commits into
mainfrom
feat/desktop-workspace-source-selector
Jul 18, 2026
Merged

feat(desktop): clarify active state in create-workspace source selector#676
skevetter merged 2 commits into
mainfrom
feat/desktop-workspace-source-selector

Conversation

@skevetter

Copy link
Copy Markdown
Contributor

Summary

The create-workspace wizard used a Tabs strip to switch between Git Repo, Local Directory, and Image, but its active state was too low-contrast to read at a glance (reported in #671).

  • Replace the tab strip with a ToggleGroup segmented control (the shadcn-svelte component added in feat(desktop): add shadcn-svelte config and Toggle/ToggleGroup components #674).
  • Each option shows an icon, label, and one-line hint; the selected option is unmistakable via primary color, a primary tint, and a primary border.
  • Source panels now render as conditionals on the selected source type instead of Tabs.Content, so the selector and its panels use one component system.
  • The source type can never become empty (single-select deselection is guarded).

Depends on #674 (already merged).

Addresses the source-selector portion of #671.

Replace the low-contrast Tabs strip for Git Repo / Local Directory /
Image with a ToggleGroup segmented control. Each option shows an icon,
label, and hint, and the active option is unmistakable via primary
color, tint, and border. Panels render conditionally on the selected
source type.

Addresses the source-selector portion of #671.
@netlify

netlify Bot commented Jul 17, 2026

Copy link
Copy Markdown

Deploy Preview for images-devsy-sh canceled.

Name Link
🔨 Latest commit 293533e
🔍 Latest deploy log https://app.netlify.com/projects/images-devsy-sh/deploys/6a5aa17541815d00072f7ef5

@netlify

netlify Bot commented Jul 17, 2026

Copy link
Copy Markdown

Deploy Preview for devsydev canceled.

Name Link
🔨 Latest commit 293533e
🔍 Latest deploy log https://app.netlify.com/projects/devsydev/deploys/6a5aa1759af4a50008db649c

@coderabbitai

coderabbitai Bot commented Jul 17, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@skevetter, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 1 minute

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 78194843-a7b5-408f-9358-d064b3c36b8f

📥 Commits

Reviewing files that changed from the base of the PR and between fcaccf5 and 293533e.

📒 Files selected for processing (3)
  • desktop/e2e/integration.e2e.ts
  • desktop/e2e/workspaces.e2e.ts
  • desktop/src/renderer/src/lib/components/workspace/WorkspaceWizard.svelte

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

The source selector no longer uses Tabs, so role="tabpanel" is gone.
Tag each source panel with data-testid="source-panel" and update the
e2e template-selection locators to match.
@skevetter
skevetter merged commit 9acc6af into main Jul 18, 2026
28 checks passed
@skevetter
skevetter deleted the feat/desktop-workspace-source-selector branch July 18, 2026 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant