fix(feature): interpolate documentation URL and feature id in wrapper script#736
Merged
Merged
Conversation
… script
The feature install wrapper script contained two JS template-literal
expressions left over from the upstream TypeScript devcontainers CLI that
were pasted verbatim into Go raw strings and never interpolated:
- ${documentation} in the troubleshooting message printed literally
instead of the feature's documentation URL.
- ${escapeQuotesForShell(feature.id)} in the deprecation warning printed
a literal JS function call instead of the feature id.
Replace both with Go string concatenation of the already-escaped values.
✅ Deploy Preview for images-devsy-sh canceled.
|
✅ Deploy Preview for devsydev canceled.
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughChangesFeature wrapper script fixes
Estimated code review effort: 1 (Trivial) | ~5 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
skevetter
marked this pull request as ready for review
July 24, 2026 15:34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The feature install wrapper script (
pkg/devcontainer/feature/features.go) contained two JS template-literal expressions left over from the upstream TypeScript devcontainers CLI. They were pasted verbatim into Go raw strings and never interpolated, so they printed literally.${documentation}in the troubleshooting message printed literally instead of the feature's documentation URL. Users saw:${escapeQuotesForShell(feature.id)}in the deprecation warning printed a literal JS function call instead of the feature id.Both are replaced with Go string concatenation of the already-escaped
documentation/idvalues, matching how the other fields (e.g.Documentation :) are already handled.This is a cosmetic message fix; it does not change install behavior.
Summary by CodeRabbit