fix(temporal): prevent panic on multi-byte UTF-8 queries#24
Open
majkelooo wants to merge 1 commit intodevwhodevs:mainfrom
Open
fix(temporal): prevent panic on multi-byte UTF-8 queries#24majkelooo wants to merge 1 commit intodevwhodevs:mainfrom
majkelooo wants to merge 1 commit intodevwhodevs:mainfrom
Conversation
`find_iso_date_in_query` iterates byte indices but slices `&str`, which panics when an index falls inside a multi-byte character (e.g. Polish ą, ś, ź, ż). Add `is_char_boundary` guards before slicing. Reproducer: `engraph search "powiązania między klientami"` Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
find_iso_date_in_query()insrc/temporal.rsiterates over byte indices (bytes.len()) but then slices&strusing those indices (&query[i..i + 10])is_char_boundary()guards before slicing to skip non-boundary positionsReproducer
Any query containing Polish, Czech, German (ü, ö), or other non-ASCII characters at specific byte offsets triggers this.
Fix
Test plan
engraph search "powiązania między klientami"— was panic, now returns resultsengraph search "księgowość rozliczenia"— was panic, now returns resultsengraph search "świadczenie usług"— was panic, now returns resultscargo build --releasepasses🤖 Generated with Claude Code