docs: fix CLAUDE.md module list, targets, and build JDK#146
Merged
Conversation
CLAUDE.md described kuri as a single module, when settings.gradle.kts declares three (:kuri, :kuri-bind, :kuri-serde-kotlinx), each carrying production source, the full quality-gate stack, and its own Java-8 toolchain override that has to track :kuri's. It also omitted Android from the target list even though it's a fully wired, published target with a hand-registered androidApiCheck task that public-API changes need to account for, and it still named Corretto 25 as the build JDK when gradle-daemon-jvm.properties and every CI workflow pin Corretto 21. Closes #92, closes #93, closes #115
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
:kuricore engine,:kuri-bindJVM-only reflective binder,:kuri-serde-kotlinxkotlinx.serialization bridge) instead of only:kuri, since all three carry production source and the full quality-gate stack and each of the latter two pins its own Java-8 toolchain override that has to stay in sync with:kuri's.:kuritarget list, with a note on the hand-wiredandroidApiCheck/androidApiDumptasks (the KMP Android library plugin doesn't auto-wire BCV for its single-variant target) so contributors editing the public API know to regenerate the Android ABI snapshot too.gradle/gradle-daemon-jvm.propertiesand everyactions/setup-javastep in CI.site/src/content/docs/guides/platforms.mdx(also flagged in #93) doesn't exist onmainyet — it currently only exists on the not-yet-mergeddocs/astro-sitebranch — so there's nothing to fix there from this branch.Test plan
settings.gradle.kts,kuri/build.gradle.kts,kuri-bind/build.gradle.kts,kuri-serde-kotlinx/build.gradle.kts,gradle/gradle-daemon-jvm.properties, and theactions/setup-javasteps in.github/workflows/{ci,codeql,publish}.yml.Closes #92
Closes #93
Closes #115